Commit 9025991a authored by Nick Mathewson's avatar Nick Mathewson 🦀
Browse files

Fix a few warnings from lintChanges

parent f564777f

changes/bug20530

+2 −2
Original line number Diff line number Diff line 
  o Minor Fixes (Windows):

  o Minor bugfixes (Windows):

    - Check for getpagesize before using it to mmap files. This fixes

      compilation in some MinGW environments. Fixes bug 20530; bugfix on

      commit bf72878 in tor-0.1.2.1-alpha, reported by "ice".
 
      0.1.2.1-alpha. Reported by "ice".

changes/bug20646

+3 −3
Original line number Diff line number Diff line 
  o Minor bugfix (util)

  o Minor bugfix (util):

    - When finishing writing a file to disk, if we were about to replace the

      file with the temporary file created before and we fail to replace it,

      remove the temporary file so it doesn't stay on disk. Closes #20646;

      bugfix on tor-0.2.0.7-alpha; Patch by fk.
 
      remove the temporary file so it doesn't stay on disk. Fixes bug 20646;

      bugfix on tor-0.2.0.7-alpha. Patch by fk.

changes/feature17238

+2 −2
Original line number Diff line number Diff line 
  o Major features (onion service)

  o Major features (onion services):

    - Tor relays now support the HSDir version 3 protocol meaning they can

      store and serve v3 descriptors. This is part of the next generation

      onion service work detailled in proposal 224. The tor daemon also

      contains all the necessary code to encode and decode a v3 descriptor but

      it's currently only used by the directory subsystem. Closes #17238.
 
      it's currently only used by the directory subsystem. Closes ticket 17238.

changes/feature20552

+1 −1
Original line number Diff line number Diff line 
  o Minor features (ed25519 link handshake):

    - Advertise support for the ed25519 link handshake using the

      subprotocol-versions mechanism, so that clients can tell which

      relays can identity themselves by Ed25519 ID.
 
      relays can identity themselves by Ed25519 ID. Closes ticket 20552.

changes/ticket18873

+8 −5
Original line number Diff line number Diff line 
  o Code simplification and refactoring:

    - Extracted dummy_origin_circuit_new so it can be used by other test

    - Refactor circuit_predict_and_launch_new for readability and

      testability. Closes ticket 18873.

    - Extract magic numbers in circuituse.c into defined variables.

    - Refactor circuit_is_available_for_use to remove unnecessary check.



  o Minor features (unit tests):

    - Extract dummy_origin_circuit_new so it can be used by other test

      functions.

    - Refactor circuit_predict_and_launch_new for readability and testability.

    - Added unit tests for extracted functions.

    - Extracted magic numbers in circuituse.c into defined variables.

    - Refactor circuit_is_available_for_use to remove unnecessary check
 
    - Add unit tests circuit_predict_and_launch_new.