Commit 9bb34aa8 authored by Nick Mathewson's avatar Nick Mathewson 🦀
Browse files

Survive fedora's openssl in our benchmarks 

Apparently fedora currently has ECDH but not P224. This isn't a huge
deal, since we no longer use OpenSSL's P224 ever (see #9780 and
72c1e5ac). But we shouldn't have segfaulting benchmarks really.

Fixes bug 10835; bugfix on 0.2.4.8-alpha.
parent a7e94659

changes/bug10835

0 → 100644
+4 −0
Original line number Diff line number Diff line 
  o Minor bugfixes (testing):

    - Fix a segmentation fault in our benchmark code when running with

      Fedora's OpenSSL package, or any other OpenSSL that provides

      ECDH but not P224. Fixes bug 10835; bugfix on 0.2.4.8-alpha.

src/test/bench.c

+4 −0
Original line number Diff line number Diff line
@@ -440,6 +440,10 @@ bench_ecdh_impl(int nid, const char *name) 
    ssize_t slen_a, slen_b;

    EC_KEY *dh_a = EC_KEY_new_by_curve_name(nid);

    EC_KEY *dh_b = EC_KEY_new_by_curve_name(nid);

    if (!dh_a || !dh_b) {

      puts("Skipping.  (No implementation?)");

      return;

    }



    EC_KEY_generate_key(dh_a);

    EC_KEY_generate_key(dh_b);