Commit 0c984e0e authored by David Goulet's avatar David Goulet 🐼
Browse files

conn: Notify btrack subsys on normal OR conn close 



Fixes #40604

Signed-off-by: David Goulet's avatarDavid Goulet <dgoulet@torproject.org>
parent 691e542f

changes/ticket40604

0 → 100644
+5 −0
Original line number Diff line number Diff line 
  o Major bugfixes (relay):

    - Remove OR connections btrack subsystem entries when the connections

      closes normally. Before this, we would only close it on error and thus

      leaking memory for each normal OR connections. Fixes bug 40604; bugfix

      on 0.4.0.1-alpha.

src/core/or/connection_or.c

+4 −0
Original line number Diff line number Diff line
@@ -799,6 +799,10 @@ connection_or_about_to_close(or_connection_t *or_conn) 
  } else if (!tor_digest_is_zero(or_conn->identity_digest)) {

    connection_or_event_status(or_conn, OR_CONN_EVENT_CLOSED,

                tls_error_to_orconn_end_reason(or_conn->tls_error));

  } else {

    /* Normal close, we notify of a done connection. */

    connection_or_event_status(or_conn, OR_CONN_EVENT_CLOSED,

                               END_OR_CONN_REASON_DONE);

  }

}