Commit af4192b1 authored by Roger Dingledine's avatar Roger Dingledine
Browse files

start tracking a rare bug: package_raw_inbuf gets called with package_window 0

Nov 25 22:39:18.294 [warn] connection_edge_package_raw_inbuf(): called with package_window 0. T
ell Roger.


svn:r870
parent 3d37291e
...@@ -53,6 +53,10 @@ int connection_edge_process_inbuf(connection_t *conn) { ...@@ -53,6 +53,10 @@ int connection_edge_process_inbuf(connection_t *conn) {
return 0; return 0;
case AP_CONN_STATE_OPEN: case AP_CONN_STATE_OPEN:
case EXIT_CONN_STATE_OPEN: case EXIT_CONN_STATE_OPEN:
if(conn->package_window <= 0) {
log_fn(LOG_WARN,"called with package_window %d. Tell Roger.", conn->package_window);
return 0;
}
if(connection_edge_package_raw_inbuf(conn) < 0) { if(connection_edge_package_raw_inbuf(conn) < 0) {
connection_edge_end(conn, END_STREAM_REASON_MISC, conn->cpath_layer); connection_edge_end(conn, END_STREAM_REASON_MISC, conn->cpath_layer);
return -1; return -1;
......
...@@ -713,7 +713,7 @@ router_resolve_directory(directory_t *dir) ...@@ -713,7 +713,7 @@ router_resolve_directory(directory_t *dir)
for (i = 0; i < max; ++i) { for (i = 0; i < max; ++i) {
remove = 0; remove = 0;
if (router_resolve(dir->routers[i])) { if (router_resolve(dir->routers[i])) {
log_fn(LOG_WARN, "Couldn't resolve router %s; removing", log_fn(LOG_WARN, "Couldn't resolve router %s; not using",
dir->routers[i]->address); dir->routers[i]->address);
remove = 1; remove = 1;
} else if (options.Nickname && } else if (options.Nickname &&
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment