Recent Python3 versions seem to require this on Windows.

Fixes bug 26535; bug introduced in f4be34f7, which
was apparently intended itself as a Python3 workaround.

This check was added by mistake long ago.  It will be nice to see
these EOLs disappear from our code over time.

(backport from master)

Bug not in any released Tor.

This patch fixes a memory leak in test_sr_setup_commits() where the
place_holder is allocated, but never freed again.

See: Coverity CID 1437440.

This patch fixes a memory leak in disk_state_parse_commits() where if
commit is NULL, we continue the internal loop, but without ever freeing
the args variable.

See: Coverity CID 1437441.

This patch fixes a memory leak in frac_nodes_with_descriptors() where
we might return without free'ing the bandwidths variable.

See: Coverity CID 1437451.

This patch fixes a potential memory leak in test_hs_auth_cookies() if a
test-case fails and we goto the done label where no memory clean up is
done.

See: Coverity CID 1437453

Closes ticket 26372.

Fixes bug 26269; bugfix on c30be5a8 in 0.2.8.2-alpha

rl1987 authored Jun 04, 2018 and Nick Mathewson committed Jun 08, 2018

and contract_protocol_list()

Apparently, contrary to its documentation, this is how OpenSSL now
wants us to report an error.

Fixes bug 26116; bugfix on 0.2.5.16.

Fixes bug 26072; bugfix on 0.2.4.7-alpha.

The any_client_port_set() returns true if the ControlPort is set which is
wrong because we can have that port open but still not behave as a tor client
(like many relays for instance).

Fixes #26062
Signed-off-by: David Goulet <dgoulet@torproject.org>

teor authored May 02, 2018 and juga committed May 09, 2018

When directory authorities read a zero-byte bandwidth file, they log
a warning with the contents of an uninitialised buffer. Log a warning
about the empty file instead.

Fixes bug 26007; bugfix on 0.2.2.1-alpha.

When directory authorities read a zero-byte bandwidth file, they log
a warning with the contents of an uninitialised buffer. Log a warning
about the empty file instead.

Fixes bug 26007; bugfix on 0.2.2.1-alpha.

When Travis CI runs make distcheck, test-suite.log doesn't exist in
the expected place.  Add a new make target to show this file and use
it when DISTCHECK=yes in .travis.yml.  Fixes bug 25814; bug not in any
released Tor.

Fixes bug 24969; bugfix on 0.2.5.1-alpha when the sandbox was introduced.

Implements 25814.

Closes ticket 25818.