Commit c5817a0d authored by David Goulet's avatar David Goulet 🐼
Browse files

m4: Change LIBS order of TOR_SEARCH_LIBRARY() 



Some gcc versions do explode if the order of the linker flags are not correct.
One issue was statically building OpenSSL which would require that "-lssl
-lcrypto" be put _before_ the "-lpthread -ldl" flags.

I have not such problem with GCC 10 but does with GCC 9.

Closes #33624

Signed-off-by: David Goulet's avatarDavid Goulet <dgoulet@torproject.org>
parent c931eae9

acinclude.m4

+2 −2
Original line number Diff line number Diff line
@@ -166,7 +166,7 @@ AC_CACHE_CHECK([for $1 directory], tor_cv_library_$1_dir, [ 


  for tor_trydir in "$try$1dir" "(system)" "$prefix" /usr/local /usr/pkg $8; do

    LDFLAGS="$tor_saved_LDFLAGS"

    LIBS="$tor_saved_LIBS $3"

    LIBS="$3 $tor_saved_LIBS"

    CPPFLAGS="$tor_saved_CPPFLAGS"



    if test -z "$tor_trydir" ; then
@@ -219,7 +219,7 @@ AC_CACHE_CHECK([for $1 directory], tor_cv_library_$1_dir, [ 
  CPPFLAGS="$tor_saved_CPPFLAGS"

]) dnl end cache check



LIBS="$LIBS $3"

LIBS="$3 $LIBS"

if test "$tor_cv_library_$1_dir" != "(system)"; then

   TOR_EXTEND_CODEPATH($tor_cv_library_$1_dir)

fi

changes/ticket33624

0 → 100644
+5 −0
Original line number Diff line number Diff line 
  o Minor bugfixes (configure, static build):

    - Change our search library configure macro linker flag order so it works

      for certain compilers that need the right order. Fixes bug 33624; bugfix

      on 0.1.1.0-alpha.