Commit a88fa71f authored by Nick Mathewson's avatar Nick Mathewson 🐚
Browse files

Resolve XXXs from fixup-features.

Some of these seem spurious: it looks like fixup-features resolved
an issue and then complained about it too.  I'll investigate further.
parent f8ee830a
Loading
Loading
Loading
Loading
+2 −2
Original line number Diff line number Diff line
@@ -85,7 +85,8 @@ experimental = [
    "tor-netdoc/experimental",
    "tor-dirmgr/experimental",
    "tor-circmgr/experimental",
    "tor-config/experimental", "keymgr",
    "tor-config/experimental",
    "keymgr",
]

# Enable experimental APIs that are not yet officially supported.
@@ -98,7 +99,6 @@ error_detail = ["__is_experimental"]
onion-service-client = ["tor-hsclient", "tor-hscrypto"]
rpc = ["tor-rpcbase", "__is_experimental"]

# XXXX Mark as full, experimental, or non-additive!
keymgr = ["tor-keymgr/keymgr", "tor-hsclient/keymgr", "__is_experimental"]
__is_experimental = []

+1 −4
Original line number Diff line number Diff line
@@ -20,9 +20,6 @@ thiserror = "1"
tor-error = { path = "../tor-error", version = "0.5.1" }

[features]
# XXXX Mark as full, experimental, or non-additive!

# XXXX This is reachable from 'default', but from 'full'.
embedded-db = []
default = ["embedded-db"]
full = ["tor-error/full"]
full = ["tor-error/full", "embedded-db"]
+0 −1
Original line number Diff line number Diff line
@@ -14,7 +14,6 @@ repository = "https://gitlab.torproject.org/tpo/core/arti.git/"
[features]
default = []

# XXXX Mark as full, experimental, or non-additive!
keymgr = ["tor-keymgr/keymgr", "__is_experimental"]
full = [
    "retry-error/full",
+0 −1
Original line number Diff line number Diff line
@@ -18,7 +18,6 @@ default = []
# These APIs are not covered by semantic versioning.  Using this
# feature voids your "semver warrantee".

# XXXX Mark as full, experimental, or non-additive!
keymgr = ["__is_experimental", "tor-error/experimental"]
__is_experimental = []
full = ["fs-mistrust/full", "tor-error/full", "tor-hscrypto/full", "tor-llcrypto/full"]
+2 −3
Original line number Diff line number Diff line
@@ -35,11 +35,10 @@ full = [
    "tor-hscrypto?/full",
]

experimental = ["experimental-api", "hs-client", "hs-service", "ntor_v3", "stream-ctrl", "testing"]
experimental = ["experimental-api", "hs-service", "ntor_v3", "stream-ctrl", "testing"]
ntor_v3 = ["__is_experimental"]

# XXXX This is experimental, but reachable from 'full'.
hs-client = ["hs-common", "__is_experimental"]
hs-client = ["hs-common"]
hs-service = ["hs-common", "__is_experimental"]
hs-common = ["tor-hscrypto"]
experimental-api = ["__is_experimental"]