Commit a8bdb851 authored by Taylor Yu's avatar Taylor Yu
Browse files

Don't disable an unsupported compiler warning 

Conditionalize the pragma that temporarily disables
-Wunused-const-variable.  Some versions of gcc don't support it.  We
need to do this because of an apparent bug in some libzstd headers.
Fixes bug 26785; bugfix on 0.3.2.11.
parent be3a962c

changes/bug26785

0 → 100644
+4 −0
Original line number Diff line number Diff line 
  o Minor bugfixes (compilation, portability):

    - Don't try to use a pragma to temporarily disable

      -Wunused-const-variable if the compiler doesn't support it.

      Fixes bug 26785; bugfix on 0.3.2.11.

configure.ac

+3 −0
Original line number Diff line number Diff line
@@ -2143,6 +2143,9 @@ dnl -Wthread-safety-precise 
  if test "$tor_cv_cflags__Woverlength_strings" = "yes"; then

    AC_DEFINE([HAVE_CFLAG_WOVERLENGTH_STRINGS], 1, [True if we have -Woverlength-strings])

  fi

  if test "$tor_cv_cflags__warn_unused_const_variable_2" = "yes"; then

    AC_DEFINE([HAVE_CFLAG_WUNUSED_CONST_VARIABLE], 1, [True if we have -Wunused-const-variable])

  fi



  if test "x$enable_fatal_warnings" = "xyes"; then

    # I'd like to use TOR_CHECK_CFLAGS here, but I can't, since the

src/common/compress_zstd.c

+4 −0
Original line number Diff line number Diff line
@@ -19,10 +19,14 @@ 
#include "compress_zstd.h"



#ifdef HAVE_ZSTD

#ifdef HAVE_CFLAG_WUNUSED_CONST_VARIABLE

DISABLE_GCC_WARNING(unused-const-variable)

#endif

#include <zstd.h>

#ifdef HAVE_CFLAG_WUNUSED_CONST_VARIABLE

ENABLE_GCC_WARNING(unused-const-variable)

#endif

#endif



/** Total number of bytes allocated for Zstandard state. */

static atomic_counter_t total_zstd_allocation;