Commit 57e35ad3 authored by Nick Mathewson's avatar Nick Mathewson 🦀
Browse files

Avoid possible segfault when handling networkstatus vote with bad flavor 

Fix for 6530; fix on 0.2.2.6-alpha.
parent 4e7552e5

changes/bug6530

0 → 100644
+4 −0
Original line number Diff line number Diff line 
  o Major bugfixes:

    - Avoid a read of uninitializd RAM when reading a vote or consensus

      document with an unrecognized flavor name.  Fixes bug 6530; bugfix on

      0.2.2.6-alpha.

src/or/routerparse.c

+1 −1
Original line number Diff line number Diff line
@@ -2821,7 +2821,7 @@ networkstatus_parse_vote_from_string(const char *s, const char **eos_out, 
    int flavor = networkstatus_parse_flavor_name(tok->args[1]);

    if (flavor < 0) {

      log_warn(LD_DIR, "Can't parse document with unknown flavor %s",

               escaped(tok->args[2]));

               escaped(tok->args[1]));

      goto err;

    }

    ns->flavor = flav = flavor;