Commit 15ab4b46 authored by kycn's avatar kycn
Browse files

Bug 1836285 - Revert "Bug 1815015 - Set the activeness of the browser to false... 

Bug 1836285 - Revert "Bug 1815015 - Set the activeness of the browser to false by default at the time of its creation. r=geckoview-reviewers,calu"

This reverts commit 9f2f3c60d6e832ba3461eda7cdde310bfce9440c.

Differential Revision: https://phabricator.services.mozilla.com/D179717
parent fa7b9470

mobile/android/chrome/geckoview/geckoview.js

+0 −4
Original line number Diff line number Diff line
@@ -545,10 +545,6 @@ function createBrowser() { 
  browser.setAttribute("remoteType", E10SUtils.DEFAULT_REMOTE_TYPE);

  browser.setAttribute("messagemanagergroup", "browsers");



  // The browser starts up as inactive for a tab by default.

  // See: https://bugzilla.mozilla.org/show_bug.cgi?id=1815015

  browser.setAttribute("initiallyactive", "false");



  // This is only needed for mochitests, so that they honor the

  // prefers-color-scheme.content-override pref. GeckoView doesn't set this

  // pref to anything other than the default value otherwise.

mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/rule/GeckoSessionTestRule.java

+0 −3
Original line number Diff line number Diff line
@@ -139,7 +139,6 @@ public class GeckoSessionTestRule implements TestRule { 


  public void addDisplay(final GeckoSession session, final int x, final int y) {

    final GeckoDisplay display = session.acquireDisplay();

    session.setActive(true);



    final SurfaceTexture displayTexture = new SurfaceTexture(0);

    displayTexture.setDefaultBufferSize(x, y);
@@ -164,7 +163,6 @@ public class GeckoSessionTestRule implements TestRule { 
    displaySurface.release();

    final SurfaceTexture displayTexture = mDisplayTextures.remove(session);

    displayTexture.release();

    session.setActive(false);

  }



  /**
@@ -1317,7 +1315,6 @@ public class GeckoSessionTestRule implements TestRule { 
          };



      session.open(getRuntime());

      session.setActive(true);



      UiThreadUtils.waitForCondition(

          () -> mCallRecordHandler == null, env.getDefaultTimeoutMillis());

mobile/android/test_runner/src/main/java/org/mozilla/geckoview/test_runner/TestRunnerActivity.java

+0 −3
Original line number Diff line number Diff line
@@ -78,13 +78,11 @@ public class TestRunnerActivity extends Activity { 
      sessionDisplay = session.acquireDisplay();

      sessionDisplay.surfaceChanged(

          new GeckoDisplay.SurfaceInfo.Builder(surface).size(width, height).build());

      session.setActive(true);

    }



    public void release(final GeckoSession session) {

      sessionDisplay.surfaceDestroyed();

      session.releaseDisplay(sessionDisplay);

      session.setActive(false);

    }

  }
@@ -344,7 +342,6 @@ public class TestRunnerActivity extends Activity { 
    session.setContentDelegate(mContentDelegate);

    session.setPermissionDelegate(mPermissionDelegate);

    session.setPromptDelegate(mPromptDelegate);

    session.setActive(active);



    final WebExtension.SessionController sessionController = session.getWebExtensionController();

    for (final ExtensionWrapper wrapper : mExtensions.values()) {