Commit 1b5cf105 authored by Andrew McCreight's avatar Andrew McCreight
Browse files

Bug 1759432 - Don't check for the WebVR pref in VRProcessChild::Init. r=jgilbert 

This check seems to fail even if the VR pref is enabled. I think this is
because we are running this code while very early in process startup.
I think it will not introduce risk because the other process in this case
will be the parent process, so if that's been taken over then we've already
lost.

This also seems to fix the leak that I had to ignore before, probably
because the VR process wasn't even starting up properly before, so I've
removed the leak threshold I had to add.

Differential Revision: https://phabricator.services.mozilla.com/D141170
parent 7471bb63

gfx/vr/ipc/VRProcessChild.cpp

+0 −5
Original line number Diff line number Diff line
@@ -30,11 +30,6 @@ VRParent* VRProcessChild::GetVRParent() { 
}



bool VRProcessChild::Init(int aArgc, char* aArgv[]) {

  if (!StaticPrefs::dom_vr_enabled() && !StaticPrefs::dom_vr_webxr_enabled()) {

    NS_WARNING("VR is not enabled when trying to create a VRParent");

    return false;

  }



  Maybe<const char*> parentBuildID =

      geckoargs::sParentBuildID.Get(aArgc, aArgv);

  if (parentBuildID.isNothing()) {

testing/web-platform/meta/webvr/__dir__.ini

+0 −1
Original line number Diff line number Diff line 
prefs: [dom.vr.enabled:true, dom.vr.prompt.testing:true, dom.vr.prompt.testing.allow:true, dom.security.featurePolicy.experimental.enabled:true, dom.security.featurePolicy.header.enabled:true, dom.security.featurePolicy.webidl.enabled:true]
 
leak-threshold: [vr:500]