Commit 4612d82e authored by Kagami Sascha Rosylight's avatar Kagami Sascha Rosylight
Browse files

Bug 1831044 - Remove redundant *Throws attributes in URL r=webidl,smaug 

D34766 removed the usages by not using URLWorker on those methods.

Differential Revision: https://phabricator.services.mozilla.com/D176989
parent fa6606c9

dom/url/URL.cpp

+2 −2
Original line number Diff line number Diff line
@@ -190,7 +190,7 @@ void URL::SetHref(const nsAString& aHref, ErrorResult& aRv) { 
  UpdateURLSearchParams();

}



void URL::GetOrigin(nsAString& aOrigin, ErrorResult& aRv) const {

void URL::GetOrigin(nsAString& aOrigin) const {

  nsresult rv = nsContentUtils::GetUTFOrigin(URI(), aOrigin);

  if (NS_WARN_IF(NS_FAILED(rv))) {

    aOrigin.Truncate();
@@ -202,7 +202,7 @@ void URL::GetProtocol(nsAString& aProtocol) const { 
  aProtocol.Append(char16_t(':'));

}



void URL::SetProtocol(const nsAString& aProtocol, ErrorResult& aRv) {

void URL::SetProtocol(const nsAString& aProtocol) {

  nsAString::const_iterator start;

  aProtocol.BeginReading(start);

dom/url/URL.h

+2 −2
Original line number Diff line number Diff line
@@ -73,11 +73,11 @@ class URL final : public URLSearchParamsObserver, public nsWrapperCache { 


  void SetHref(const nsAString& aHref, ErrorResult& aRv);



  void GetOrigin(nsAString& aOrigin, ErrorResult& aRv) const;

  void GetOrigin(nsAString& aOrigin) const;



  void GetProtocol(nsAString& aProtocol) const;



  void SetProtocol(const nsAString& aProtocol, ErrorResult& aRv);

  void SetProtocol(const nsAString& aProtocol);



  void GetUsername(nsAString& aUsername) const;

dom/webidl/URL.webidl

+1 −3
Original line number Diff line number Diff line
@@ -5,7 +5,7 @@ 
 *

 * The origins of this IDL file are

 * http://url.spec.whatwg.org/#api

 * http://dev.w3.org/2006/webapi/FileAPI/#creating-revoking

 * https://w3c.github.io/FileAPI/#creating-revoking

 *

 * Copyright © 2012 W3C® (MIT, ERCIM, Keio), All Rights Reserved. W3C

 * liability, trademark and document use rules apply.
@@ -21,9 +21,7 @@ interface URL { 


  [SetterThrows]

  stringifier attribute USVString href;

  [GetterThrows]

  readonly attribute USVString origin;

  [SetterThrows]

           attribute USVString protocol;

           attribute USVString username;

           attribute USVString password;