From 5efdc0668f4da7053ed5666df5bad2d2ff6441f9 Mon Sep 17 00:00:00 2001
From: Erik Nordin <enordin@mozilla.com>
Date: Fri, 9 Jun 2023 15:56:03 +0000
Subject: [PATCH] Bug 1837389 - Update failing CI test case r=gregtatum,
a=test-only
Fixes a test that works for firefox versions <= the
major version, but fails when bumping the minor version.
This was a logic error in the test that was not exposed
until a minor version bump.
Differential Revision: https://phabricator.services.mozilla.com/D180357
---
.../translations/tests/browser/browser_remote_settings.js | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/toolkit/components/translations/tests/browser/browser_remote_settings.js b/toolkit/components/translations/tests/browser/browser_remote_settings.js
index c224745f4d499..c77201e45de6e 100644
--- a/toolkit/components/translations/tests/browser/browser_remote_settings.js
+++ b/toolkit/components/translations/tests/browser/browser_remote_settings.js
@@ -13,7 +13,7 @@ const { RemoteSettings } = ChromeUtils.importESModule(
);
// The full Firefox version string.
-const firefoxFullVersion = AppConstants.MOZ_APP_VERSION;
+const firefoxFullVersion = AppConstants.MOZ_APP_VERSION_DISPLAY;
// The Firefox major version string (i.e. the first set of digits).
const firefoxMajorVersion = firefoxFullVersion.match(/\d+/);
@@ -77,8 +77,8 @@ add_task(async function test_filter_current_firefox_version() {
filter_expression: ``,
},
{
- name: `env.version <= ${firefoxMajorVersion}`,
- filter_expression: `env.version|versionCompare('${firefoxMajorVersion}') <= 0`,
+ name: `env.version == ${firefoxFullVersion}`,
+ filter_expression: `env.version|versionCompare('${firefoxFullVersion}') == 0`,
},
{
name: `env.version > ${firefoxAlphaZeroVersion}`,
--
GitLab