Commit 669bf37e authored by Emilio Cobos Alvarez's avatar Emilio Cobos Alvarez
Browse files

Bug 1735465 - Make treecols look good on Windows dark mode by default.... 

Bug 1735465 - Make treecols look good on Windows dark mode by default. r=desktop-theme-reviewers,dao

Differential Revision: https://phabricator.services.mozilla.com/D128479
parent 362943a2

browser/themes/windows/places/organizer.css

+1 −16
Original line number Diff line number Diff line
@@ -43,7 +43,7 @@ 
    --organizer-outline-color: rgb(0,97,224);



    --organizer-separator-color: var(--organizer-pane-field-border-color);

    --organizer-border-color: hsla(210,4%,10%,.14);

    --organizer-border-color: ThreeDLightShadow;



    --organizer-toolbar-field-background: rgb(240,240,244);

    --organizer-toolbar-field-background-focused: Field;
@@ -66,8 +66,6 @@ 
      --organizer-selected-background: rgb(91,91,102);

      --organizer-outline-color: rgb(0,221,255);



      --organizer-border-color: rgba(249,249,250,.1);



      --organizer-toolbar-field-background: rgb(28,27,34);

      --organizer-toolbar-field-background-focused: rgb(66,65,77);

      scrollbar-color: rgba(249,249,250,.4) rgba(20,20,25,.3);
@@ -225,10 +223,6 @@ 
/* Tree */



#contentView treecol {

  appearance: none;

  background-color: var(--organizer-toolbar-background);

  color: var(--organizer-color);

  border-inline-end: 1px solid var(--organizer-border-color);

  padding: 4px;

  /* Use box-shadow to draw a bottom border instead of border-bottom

   * because otherwise the items on contentView won't be perfectly
@@ -236,15 +230,6 @@ 
  box-shadow: inset 0 -1px var(--organizer-border-color)

}



#contentView treecol:hover {

  background-color: var(--organizer-hover-background);

  color: var(--organizer-hover-color);

}



#contentView treecol:hover:active {

  background-color: var(--organizer-selected-background);

}



tree {

  background-color: var(--organizer-content-background);

  color: var(--organizer-color);

toolkit/themes/shared/tree.inc.css

+2 −2
Original line number Diff line number Diff line
@@ -123,8 +123,8 @@ treecolpicker { 
  padding: 0 4px;

}



treecol:hover,

treecolpicker:hover {

treecol:where(:hover),

treecolpicker:where(:hover) {

  color: -moz-ColHeaderHoverText;

}

toolkit/themes/windows/global/tree.css

+24 −2
Original line number Diff line number Diff line
@@ -20,6 +20,28 @@ treecol[sortDirection="descending"]:not([hideheader="true"]) > .treecol-sortdire 
  list-style-image: url("chrome://global/skin/tree/sort-dsc.svg");

}



@media (-moz-toolbar-prefers-color-scheme: dark) {

  treecol,

  treecolpicker {

    appearance: none;

    background-color: ButtonFace;

    color: ButtonText;

    border-inline-start: 1px solid ThreeDLightShadow;

    box-shadow: inset 0 -1px ThreeDLightShadow;

  }

  treecol:where([ordinal="1"]) {

    border-inline-start: none;

  }

  :is(treecol, treecolpicker):where(:hover) {

    background-color: -moz-ButtonHoverFace;

    color: -moz-ButtonHoverText;

  }

  :is(treecol, treecolpicker):where(:hover:active) {

    background-color: -moz-ButtonActiveFace;

    color: -moz-ButtonActiveText;

  }

}



@media (-moz-windows-classic) {

  treecol,

  treecolpicker {
@@ -28,11 +50,11 @@ treecol[sortDirection="descending"]:not([hideheader="true"]) > .treecol-sortdire 
    border-inline-end-color: ThreeDShadow;

    border-bottom-color: ThreeDShadow;

    border-inline-start-color: ThreeDHighlight;

    box-shadow: none;

    background-color: -moz-Dialog;

  }



  treecol:hover:active,

  treecolpicker:hover:active {

  :is(treecol, treecolpicker):where(:hover:active) {

    border-top-color: ThreeDShadow;

    border-inline-end-color: ThreeDHighlight;

    border-bottom-color: ThreeDHighlight;