Commit 7163fddb authored by Emilio Cobos Álvarez's avatar Emilio Cobos Álvarez
Browse files

Bug 1673710 - Remove PBrowser.NotifyCompositorTransaction. r=sefeng 

It's dead.

Differential Revision: https://phabricator.services.mozilla.com/D94881
parent 4e03ba34

dom/ipc/BrowserChild.cpp

+0 −8
Original line number Diff line number Diff line
@@ -310,7 +310,6 @@ BrowserChild::BrowserChild(ContentChild* aManager, const TabId& aTabId, 
      mLayersId{0},

      mEffectsInfo{EffectsInfo::FullyHidden()},

      mDidFakeShow(false),

      mNotified(false),

      mTriedBrowserInit(false),

      mOrientation(hal::eScreenOrientation_PortraitPrimary),

      mIgnoreKeyPressEvent(false),
@@ -2820,13 +2819,6 @@ void BrowserChild::InitAPZState() { 
  cbc->SendPAPZConstructor(apzChild, mLayersId);

}



void BrowserChild::NotifyPainted() {

  if (!mNotified) {

    SendNotifyCompositorTransaction();

    mNotified = true;

  }

}



IPCResult BrowserChild::RecvUpdateEffects(const EffectsInfo& aEffects) {

  bool needInvalidate = false;

  if (mEffectsInfo.IsVisible() && aEffects.IsVisible() &&

dom/ipc/BrowserChild.h

+0 −3
Original line number Diff line number Diff line
@@ -449,8 +449,6 @@ class BrowserChild final : public nsMessageManagerScriptExecutor, 


  void SetBackgroundColor(const nscolor& aColor);



  void NotifyPainted();



  MOZ_CAN_RUN_SCRIPT_BOUNDARY virtual mozilla::ipc::IPCResult RecvUpdateEffects(

      const EffectsInfo& aEffects);
@@ -821,7 +819,6 @@ class BrowserChild final : public nsMessageManagerScriptExecutor, 
  Maybe<bool> mLayersConnected;

  EffectsInfo mEffectsInfo;

  bool mDidFakeShow;

  bool mNotified;

  bool mTriedBrowserInit;

  hal::ScreenOrientation mOrientation;

dom/ipc/BrowserParent.cpp

+0 −22
Original line number Diff line number Diff line
@@ -3700,28 +3700,6 @@ mozilla::ipc::IPCResult BrowserParent::RecvRemotePaintIsReady() { 
  return IPC_OK();

}



mozilla::ipc::IPCResult BrowserParent::RecvNotifyCompositorTransaction() {

  RefPtr<nsFrameLoader> frameLoader = GetFrameLoader();



  if (!frameLoader) {

    return IPC_OK();

  }



  nsIFrame* docFrame = frameLoader->GetPrimaryFrameOfOwningContent();



  if (!docFrame) {

    // Bad, but nothing we can do about it (XXX/cjones: or is there?

    // maybe bug 589337?).  When the new frame is created, we'll

    // probably still be the current render frame and will get to draw

    // our content then.  Or, we're shutting down and this update goes

    // to /dev/null.

    return IPC_OK();

  }



  docFrame->InvalidateLayer(DisplayItemType::TYPE_REMOTE);

  return IPC_OK();

}



mozilla::ipc::IPCResult BrowserParent::RecvRemoteIsReadyToHandleInputEvents() {

  // When enabling input event prioritization, input events may preempt other

  // normal priority IPC messages. To prevent the input events preempt

dom/ipc/BrowserParent.h

+0 −2
Original line number Diff line number Diff line
@@ -754,8 +754,6 @@ class BrowserParent final : public PBrowserParent, 


  mozilla::ipc::IPCResult RecvRemotePaintIsReady();



  mozilla::ipc::IPCResult RecvNotifyCompositorTransaction();



  mozilla::ipc::IPCResult RecvRemoteIsReadyToHandleInputEvents();



  mozilla::ipc::IPCResult RecvPaintWhileInterruptingJSNoOp(

dom/ipc/PBrowser.ipdl

+0 −5
Original line number Diff line number Diff line
@@ -638,11 +638,6 @@ parent: 
     */

    async RemotePaintIsReady();



    /**

     * Child informs the parent that a compositor transaction has ocurred.

     */

    async NotifyCompositorTransaction();



    /**

     * Child informs the parent that the content is ready to handle input

     * events. This is sent when the BrowserChild is created.