Commit 71c19b19 authored by Ian Kilpatrick's avatar Ian Kilpatrick Committed by moz-wptsync-bot
Browse files

Bug 1770064 [wpt PR 34119] - [TableFragmentation] Make collapsed borders... 

Bug 1770064 [wpt PR 34119] - [TableFragmentation] Make collapsed borders painting fragmentation aware, a=testonly

Automatic update from web-platform-tests
[TableFragmentation] Make collapsed borders painting fragmentation aware

This makes the NGTablePainter::PaintCollapsedBorders function
fragmentation aware. To do this we move the collapsed row geometry to
the individual sections (instead of the table) as rows can now expand
due to fragmentation (the table may not have the correct geometry).

Additionally the "joint" logic is updated to check if there is an
actual joint there or it was just fragmented.

Bug: 1078927
Change-Id: I7b591b4ef8b1a5a210b69b5dfc320f209281602b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3646093


Reviewed-by: default avatarPhilip Rogers <pdr@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: default avatarMorten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1005564}

--

wpt-commits: 70c49c6df8e33dc7013bb6408a90ffb7fa76d796
wpt-pr: 34119
parent fe2f422b

testing/web-platform/tests/css/css-break/table/table-collapsed-borders-paint-htb-ltr-ref.html

0 → 100644
+19 −0
Original line number Diff line number Diff line 
<!DOCTYPE html>

<style>

.multicol {

  inline-size: 400px;

  block-size: 100px;

  columns: 4;

  column-fill: auto;

  gap: 10px;

  padding: 10px;

  border: solid 3px;

}

</style>

<div class="multicol">

  <div style="background: dodgerblue; block-size: 120px;"></div>

  <div style="block-size: 40px; border: solid 10px lime;"></div>

  <div style="block-size: 135px; border: solid 10px; border-top: none;"></div>

  <div style="block-size: 40px; border: solid 10px blue; border-top: none;"></div>

  <div style="block-size: 15px; border: solid 10px blue; border-top: none;"></div>

</div>

testing/web-platform/tests/css/css-break/table/table-collapsed-borders-paint-htb-ltr.html

0 → 100644
+36 −0
Original line number Diff line number Diff line 
<!DOCTYPE html>

<link rel="match" href="table-collapsed-borders-paint-htb-ltr-ref.html">

<link rel="help" href="https://drafts.csswg.org/css-tables-3/#fragmentation">

<link rel="help" href="https://drafts.csswg.org/css-tables-3/#rendering">

<style>

.multicol {

  inline-size: 400px;

  block-size: 100px;

  columns: 4;

  column-fill: auto;

  gap: 10px;

  padding: 10px;

  border: solid 3px;

}

</style>

<div class="multicol">

  <table style="border-collapse: collapse; inline-size: 100%;">

    <caption style="background: dodgerblue; block-size: 120px;"></caption>

    <tbody>

      <tr style="block-size: 50px;">

        <td style="border: solid 10px lime;"></td>

      </tr>

      <tr style="block-size: 145px;">

        <td style="border: solid 10px;"></td>

      </tr>

    </tbody>

    <tbody>

      <tr style="block-size: 50px;">

        <td style="border: solid blue 10px;"></td>

      </tr>

      <tr style="block-size: 25px;">

        <td style="border: solid blue 10px;"></td>

      </tr>

    </tbody>

  </table>

</div>

testing/web-platform/tests/css/css-break/table/table-collapsed-borders-paint-vlr-rtl-ref.html

0 → 100644
+23 −0
Original line number Diff line number Diff line 
<!DOCTYPE html>

<style>

body {

  writing-mode: vertical-lr;

  direction: rtl;

}

.multicol {

  inline-size: 400px;

  block-size: 100px;

  columns: 4;

  column-fill: auto;

  gap: 10px;

  padding: 10px;

  border: solid 3px;

}

</style>

<div class="multicol">

  <div style="background: dodgerblue; block-size: 120px;"></div>

  <div style="block-size: 40px; border: solid 10px lime;"></div>

  <div style="block-size: 135px; border: solid 10px; border-left: none;"></div>

  <div style="block-size: 40px; border: solid 10px blue; border-left: none;"></div>

  <div style="block-size: 15px; border: solid 10px blue; border-left: none;"></div>

</div>

testing/web-platform/tests/css/css-break/table/table-collapsed-borders-paint-vlr-rtl.html

0 → 100644
+40 −0
Original line number Diff line number Diff line 
<!DOCTYPE html>

<link rel="match" href="table-collapsed-borders-paint-vlr-rtl-ref.html">

<link rel="help" href="https://drafts.csswg.org/css-tables-3/#fragmentation">

<link rel="help" href="https://drafts.csswg.org/css-tables-3/#rendering">

<style>

body {

  writing-mode: vertical-lr;

  direction: rtl;

}

.multicol {

  inline-size: 400px;

  block-size: 100px;

  columns: 4;

  column-fill: auto;

  gap: 10px;

  padding: 10px;

  border: solid 3px;

}

</style>

<div class="multicol">

  <table style="border-collapse: collapse; inline-size: 100%;">

    <caption style="background: dodgerblue; block-size: 120px;"></caption>

    <tbody>

      <tr style="block-size: 50px;">

        <td style="border: solid 10px lime;"></td>

      </tr>

      <tr style="block-size: 145px;">

        <td style="border: solid 10px;"></td>

      </tr>

    </tbody>

    <tbody>

      <tr style="block-size: 50px;">

        <td style="border: solid blue 10px;"></td>

      </tr>

      <tr style="block-size: 25px;">

        <td style="border: solid blue 10px;"></td>

      </tr>

    </tbody>

  </table>

</div>

testing/web-platform/tests/css/css-break/table/table-collapsed-borders-paint-vrl-ltr-ref.html

0 → 100644
+22 −0
Original line number Diff line number Diff line 
<!DOCTYPE html>

<style>

body {

  writing-mode: vertical-rl;

}

.multicol {

  inline-size: 400px;

  block-size: 100px;

  columns: 4;

  column-fill: auto;

  gap: 10px;

  padding: 10px;

  border: solid 3px;

}

</style>

<div class="multicol">

  <div style="background: dodgerblue; block-size: 120px;"></div>

  <div style="block-size: 40px; border: solid 10px lime;"></div>

  <div style="block-size: 135px; border: solid 10px; border-right: none;"></div>

  <div style="block-size: 40px; border: solid 10px blue; border-right: none;"></div>

  <div style="block-size: 15px; border: solid 10px blue; border-right: none;"></div>

</div>