Commit 763746d9 authored by Jeff Muizelaar's avatar Jeff Muizelaar
Browse files

Bug 1769839 - Record the GMP download failure reason in telemetry. r=chutten 

We're seeing a number of download failures in the field. It would be
nice to understand why they're happening.

Differential Revision: https://phabricator.services.mozilla.com/D146623
parent 9ba8c615

toolkit/components/telemetry/app/TelemetryEnvironment.jsm

+1 −0
Original line number Diff line number Diff line
@@ -331,6 +331,7 @@ const DEFAULT_ENVIRONMENT_PREFS = new Map([ 
  ["media.gmp-gmpopenh264.lastInstallStart", { what: RECORD_PREF_VALUE }],

  ["media.gmp-gmpopenh264.lastDownload", { what: RECORD_PREF_VALUE }],

  ["media.gmp-gmpopenh264.lastDownloadFailed", { what: RECORD_PREF_VALUE }],

  ["media.gmp-gmpopenh264.lastDownloadFailReason", { what: RECORD_PREF_VALUE }],

  ["media.gmp-gmpopenh264.lastUpdate", { what: RECORD_PREF_VALUE }],

  ["media.gmp-gmpopenh264.visible", { what: RECORD_PREF_VALUE }],

  ["media.gmp-manager.lastCheck", { what: RECORD_PREF_VALUE }],

toolkit/components/telemetry/docs/data/environment.rst

+2 −0
Original line number Diff line number Diff line
@@ -431,6 +431,8 @@ The following is a partial list of `collected preferences <https://searchfox.org 


- ``media.gmp-gmpopenh264.lastDownloadFailed``: When OpenH264 was last downloaded unsuccessfully as seconds since Jan 1, 1970.



- ``media.gmp-gmpopenh264.lastDownloadFailReason``: The exception value when OpenH264 was last failed to downloaded.



- ``media.gmp-gmpopenh264.lastInstallFailed``: When OpenH264 installation last failed as seconds since Jan 1, 1970.



- ``media.gmp-gmpopenh264.lastInstallStart``: When OpenH264 installation was last started as seconds since Jan 1, 1970.

toolkit/modules/GMPInstallManager.jsm

+5 −0
Original line number Diff line number Diff line
@@ -789,6 +789,11 @@ GMPDownloader.prototype = { 
        );

      },

      reason => {

        GMPPrefs.setString(

          GMPPrefs.KEY_PLUGIN_LAST_DOWNLOAD_FAIL_REASON,

          reason,

          gmpAddon.id

        );

        let now = Math.round(Date.now() / 1000);

        GMPPrefs.setInt(

          GMPPrefs.KEY_PLUGIN_LAST_DOWNLOAD_FAILED,

toolkit/modules/GMPUtils.jsm

+1 −0
Original line number Diff line number Diff line
@@ -127,6 +127,7 @@ var GMPPrefs = { 
  KEY_PLUGIN_ENABLED: "media.{0}.enabled",

  KEY_PLUGIN_LAST_DOWNLOAD: "media.{0}.lastDownload",

  KEY_PLUGIN_LAST_DOWNLOAD_FAILED: "media.{0}.lastDownloadFailed",

  KEY_PLUGIN_LAST_DOWNLOAD_FAIL_REASON: "media.{0}.lastDownloadFailReason",

  KEY_PLUGIN_LAST_INSTALL_FAILED: "media.{0}.lastInstallFailed",

  KEY_PLUGIN_LAST_INSTALL_START: "media.{0}.lastInstallStart",

  KEY_PLUGIN_LAST_UPDATE: "media.{0}.lastUpdate",