Commit 84027af8 authored by Mike Hommey's avatar Mike Hommey
Browse files

Bug 1256507 - Remove --enable-xterm-updates. r=gps 

It's an opt-in flag that allows to display where the build is in
terminal window titles. The fact that it's opt-in and likely unknown
makes it very low-value, and the fact that it was added in an era where
builds were not very well parallelized made it have a meaning, but now
that builds are parallelized, its meaningfulness is diminished.

Let's just remove it.
parent 2a18c04f

build/moz.configure/old.configure

+0 −1
Original line number Diff line number Diff line
@@ -271,7 +271,6 @@ def old_configure_options(*options): 
    '--enable-webspeech',

    '--enable-webspeechtestbackend',

    '--enable-wmf',

    '--enable-xterm-updates',

    '--enable-xul',

    '--enable-zipwriter',

    '--no-create',

config/rules.mk

+0 −12
Original line number Diff line number Diff line
@@ -287,17 +287,6 @@ ifdef HOST_SIMPLE_PROGRAMS 
GARBAGE			+= $(HOST_SIMPLE_PROGRAMS:%=%.$(OBJ_SUFFIX))

endif



ifdef MOZ_UPDATE_XTERM

# Its good not to have a newline at the end of the titlebar string because it

# makes the make -s output easier to read.  Echo -n does not work on all

# platforms, but we can trick printf into doing it.

ifeq (.,$(relativesrcdir))

UPDATE_TITLE = printf '\033]0;%s in %s\007' $(1) $(2) ;

else

UPDATE_TITLE = printf '\033]0;%s in %s\007' $(1) $(relativesrcdir)/$(2) ;

endif

endif



ifdef MACH

ifndef NO_BUILDSTATUS_MESSAGES

define BUILDSTATUS
@@ -308,7 +297,6 @@ endif 
endif



define SUBMAKE # $(call SUBMAKE,target,directory,static)

+@$(UPDATE_TITLE)

+@$(MAKE) $(if $(2),-C $(2)) $(1)



endef # The extra line is important here! don't delete it

js/src/old-configure.in

+0 −8
Original line number Diff line number Diff line
@@ -2619,14 +2619,6 @@ dnl = 
dnl ========================================================

MOZ_ARG_HEADER(Misc. Options)



dnl ========================================================

dnl update xterm title

dnl ========================================================

MOZ_ARG_ENABLE_BOOL(xterm-updates,

[  --enable-xterm-updates  Update XTERM titles with current command.],

    MOZ_UPDATE_XTERM=1,

    MOZ_UPDATE_XTERM= )



if test -z "$SKIP_COMPILER_CHECKS"; then

dnl ========================================================

dnl =

old-configure.in

+0 −9
Original line number Diff line number Diff line
@@ -7049,14 +7049,6 @@ dnl = 
dnl ========================================================

MOZ_ARG_HEADER(Misc. Options)



dnl ========================================================

dnl update xterm title

dnl ========================================================

MOZ_ARG_ENABLE_BOOL(xterm-updates,

[  --enable-xterm-updates  Update XTERM titles with current command.],

    MOZ_UPDATE_XTERM=1,

    MOZ_UPDATE_XTERM= )



dnl =========================================================

dnl = Chrome format

dnl =========================================================
@@ -7820,7 +7812,6 @@ AC_SUBST(IMPLIB) 
AC_SUBST(FILTER)

AC_SUBST(BIN_FLAGS)

AC_SUBST(MOZ_WIDGET_TOOLKIT)

AC_SUBST(MOZ_UPDATE_XTERM)

AC_SUBST(MOZ_AUTH_EXTENSION)

AC_SUBST(MOZ_PREF_EXTENSIONS)

AC_SUBST(MOZ_DEBUG)