Bug 1721503: Avoid possible lock-order inversion in shutting down...

RemoteLazyInputStreamChild::~RemoteLazyInputStreamChild() = default;

void RemoteLazyInputStreamChild::Shutdown() {

  MutexAutoLock lock(mMutex);

  RefPtr<RemoteLazyInputStreamChild> kungFuDeathGrip = this;

  // Don't delete the pending operations inside our lock, since that might

  // lead to a lock-ordering inversion

  nsTArray<PendingOperation> pending;

  {

    MutexAutoLock lock(mMutex);

    mWorkerRef = nullptr;

  mPendingOperations.Clear();

    pending.SwapElements(mPendingOperations);

    if (mState == eActive) {

      SendClose();

      mState = eInactive;

    }

  }

  // Now release pending operations.

  // We could let this be destroyed by scope, but I prefer

  // to be explicit that we clear this before we drop the

  // self-reference

  pending.Clear();

}

void RemoteLazyInputStreamChild::ActorDestroy(

    IProtocol::ActorDestroyReason aReason) {