Commit 9f7e3421 authored by Guido Urdaneta's avatar Guido Urdaneta Committed by moz-wptsync-bot
Browse files

Bug 1721618 [wpt PR 29731] - [BreakoutBox] Remove control signals, a=testonly 

Automatic update from web-platform-tests
[BreakoutBox] Remove control signals

The MediaStreamTrackSignal WebIDL dictionary should be removed in a
follow-up CL.
Not removed in this CL to avoid crbug.com/1231462 which lead to a
revert of a previous version of this CL (https://crrev.com/c/3039183).

Bug: 1231028,1231462
Change-Id: I9cb13798602b6a8440d84031d31da512d64a4b7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3041455


Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Auto-Submit: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: default avatarTony Herre <toprice@chromium.org>
Cr-Commit-Position: refs/heads/master@{#904207}

--

wpt-commits: 0ab2cdbeb7d4166b14670cc7caabab45847bdaab
wpt-pr: 29731
parent a3fc5d52

testing/web-platform/tests/mediacapture-insertable-streams/MediaStreamTrackGenerator-audio.https.html

+1 −31
Original line number Diff line number Diff line
@@ -51,23 +51,6 @@ 
      t.add_cleanup(() => generator.stop());

    }, "Tests that creating a Audio MediaStreamTrackGenerator works as expected");



    promise_test(async t => {

      const capturedStream = await navigator.mediaDevices.getUserMedia({ audio: true });

      assert_equals(capturedStream.getAudioTracks().length, 1);

      const upstreamTrack = capturedStream.getAudioTracks()[0];

      t.add_cleanup(() => upstreamTrack.stop());



      const generator = new MediaStreamTrackGenerator({ signalTarget: upstreamTrack, kind: "audio" });

      t.add_cleanup(() => generator.stop());



      const writer = generator.writable.getWriter();

      const data = makeAudioData(1);

      await writer.write(data);



      assert_equals(generator.kind, "audio");

      assert_equals(generator.readyState, "live");

    }, "Tests that creating an Audio MediaStreamTrackGenerator with a signal target works as expected");



    promise_test(async t => {

      assert_throws_js(TypeError, () => { new MediaStreamTrackGenerator({ kind: "invalid kind" }) });

    }, "Creating Generator with an invalid kind throws");
@@ -78,22 +61,9 @@ 
      const upstreamTrack = capturedStream.getAudioTracks()[0];

      t.add_cleanup(() => upstreamTrack.stop());



      assert_throws_js(TypeError, () => { new MediaStreamTrackGenerator({ signalTarget: upstreamTrack }) });

      assert_throws_js(TypeError, () => { new MediaStreamTrackGenerator() });

    }, "Creating Generator with a missing kind throws");



    promise_test(async t => {

      const capturedStream = await navigator.mediaDevices.getUserMedia({ audio: true });

      assert_equals(capturedStream.getAudioTracks().length, 1);

      const upstreamTrack = capturedStream.getAudioTracks()[0];

      t.add_cleanup(() => upstreamTrack.stop());



      assert_throws_js(TypeError, () => { new MediaStreamTrackGenerator({ signalTarget: upstreamTrack, kind: "video" }) });

    }, "Creating Generator with mismatched kinds throws");



    promise_test(async t => {

      assert_throws_js(TypeError, () => { new MediaStreamTrackGenerator({ signalTarget: "IamNotATrack" }) });

    }, "Creating Generator with invalid signalTarget throws");



    promise_test(async t => {

      const generator = new MediaStreamTrackGenerator({ kind: "video" });

      t.add_cleanup(() => generator.stop());

testing/web-platform/tests/mediacapture-insertable-streams/MediaStreamTrackGenerator-video.https.html

+0 −18
Original line number Diff line number Diff line
@@ -197,24 +197,6 @@ 
      assert_throws_dom("InvalidStateError", () => frame.clone(), "VideoFrame wasn't destroyed on write.");

    }, "Tests that VideoFrames are destroyed on write.");



    promise_test(async t => {

      const capturedStream = await navigator.mediaDevices.getUserMedia({ video: true });

      assert_equals(capturedStream.getVideoTracks().length, 1);

      const upstreamTrack = capturedStream.getVideoTracks()[0];

      t.add_cleanup(() => upstreamTrack.stop());



      const generator = new MediaStreamTrackGenerator({ signalTarget: upstreamTrack, kind: "video" });

      t.add_cleanup(() => generator.stop());



      const writer = generator.writable.getWriter();

      const frame = makeVideoFrame(1);

      await writer.write(frame);



      assert_equals(generator.kind, "video");

      assert_equals(generator.readyState, "live");

    }, "Tests that creating a Video MediaStreamTrackGenerator with a signal target works as expected");





    promise_test(async t => {

      const generator = new MediaStreamTrackGenerator("audio");

      t.add_cleanup(() => generator.stop());