Commit f0a8f73e authored by Tomislav Jovanovic's avatar Tomislav Jovanovic
Browse files

Bug 1735347 - Add fallback and some diagnostic reporting for getting FrameData r=robwu 

Same fallback for getting FrameData using sync message existed prior to D127750:

https://searchfox.org/mozilla-central/rev/7e36862b61/toolkit/components/extensions/ExtensionPageChild.jsm#595

I dropped it thinking it might not be needed anymore, but looks like it is,
and I'm adding some diagnostic error reporting to figure out when/why.

Differential Revision: https://phabricator.services.mozilla.com/D128310
parent 04fc5e05

toolkit/components/extensions/ExtensionPageChild.jsm

+5 −1
Original line number Diff line number Diff line
@@ -424,7 +424,11 @@ ExtensionPageChild = { 


    let mm = contentWindow.docShell.messageManager;

    let data = mm.sendSyncMessage("Extension:GetFrameData")[0];

    let { viewType, tabId, devtoolsToolboxInfo } = data;

    if (!data) {

      let policy = WebExtensionPolicy.getByHostname(uri.host);

      Cu.reportError(`FrameData missing for ${policy?.id} page ${uri.spec}`);

    }

    let { viewType, tabId, devtoolsToolboxInfo } = data ?? {};



    if (viewType) {

      ExtensionPageChild.expectViewLoad(mm, viewType);