Commit f6e7e29f authored by Julien Cristau's avatar Julien Cristau
Browse files

Backed out 1 changesets (bug 1708735) for multiple regressions

Backed out changeset e1a42874f276 (bug 1708735)
parent 83ed9f02
Loading
Loading
Loading
Loading
+0 −1
Original line number Diff line number Diff line
@@ -241,7 +241,6 @@
    <panel is="search-autocomplete-richlistbox-popup"
           type="autocomplete-richlistbox"
           id="PopupSearchAutoComplete"
           orient="vertical"
           role="group"
           noautofocus="true"
           hidden="true" />
+11 −12
Original line number Diff line number Diff line
@@ -360,15 +360,18 @@ async function testSelectColors(selectID, itemCount, options) {
  );
  if (options.waitForComputedStyle) {
    let property = options.waitForComputedStyle.property;
    let expectedValue = options.waitForComputedStyle.value;
    let value = options.waitForComputedStyle.value;
    await TestUtils.waitForCondition(() => {
      let node = ["background-image", "background-color"].includes(property)
        ? arrowSB
        : selectPopup;
      let value = getComputedStyle(node).getPropertyValue(property);
      info(`<${node.localName}> has ${property}: ${value}`);
      return value == expectedValue;
    }, `${selectID} - Waiting for <select> to have ${property}: ${expectedValue}`);
      info(
        `<${node.localName}> has ${property}: ${
          getComputedStyle(node)[property]
        }`
      );
      return getComputedStyle(node)[property] == value;
    }, `${selectID} - Waiting for <select> to have ${property}: ${value}`);
  }

  is(selectPopup.parentNode.itemCount, itemCount, "Correct number of items");
@@ -384,11 +387,7 @@ async function testSelectColors(selectID, itemCount, options) {
  }
  if (!options.skipSelectColorTest.color) {
    is(
      rgbaToString(
        InspectorUtils.colorToRGBA(
          getComputedStyle(selectPopup).getPropertyValue("--panel-color")
        )
      ),
      getComputedStyle(selectPopup).color,
      options.selectColor,
      selectID + " popup has expected foreground color"
    );
@@ -609,7 +608,7 @@ add_task(
    let options = {
      skipSelectColorTest: true,
      waitForComputedStyle: {
        property: "--panel-color",
        property: "color",
        value: "rgb(255, 0, 0)",
      },
    };
@@ -676,7 +675,7 @@ add_task(
      selectColor: "rgb(128, 0, 128)",
      selectBgColor: kDefaultSelectStyles.backgroundColor,
      waitForComputedStyle: {
        property: "--panel-color",
        property: "color",
        value: "rgb(128, 0, 128)",
      },
      leaveOpen: true,
+1 −1
Original line number Diff line number Diff line
@@ -5,7 +5,7 @@

async function testPanel(browser, standAlone, initial_background) {
  let panel = getPanelForNode(browser);
  let arrowContent = panel.panelContent;
  let arrowContent = panel.shadowRoot.querySelector(".panel-arrowcontent");
  let arrow = panel.shadowRoot.querySelector(".panel-arrow");

  let checkArrow = (background = null) => {
+1 −1
Original line number Diff line number Diff line
@@ -35,7 +35,7 @@ add_task(async function testPopupBorderRadius() {

  async function testPanel(browser, standAlone = true) {
    let panel = getPanelForNode(browser);
    let arrowContent = panel.panelContent;
    let arrowContent = panel.shadowRoot.querySelector(".panel-arrowcontent");

    let panelStyle = getComputedStyle(arrowContent);
    is(
+2 −2
Original line number Diff line number Diff line
@@ -44,7 +44,7 @@
        </vbox>
        <arrowscrollbox class="menupopup-arrowscrollbox" flex="1" orient="vertical"
                        exportparts="scrollbox: arrowscrollbox-scrollbox"
                        smoothscroll="false" part="arrowscrollbox content">
                        smoothscroll="false" part="arrowscrollbox">
          <html:slot></html:slot>
        </arrowscrollbox>
      </hbox>
@@ -618,7 +618,7 @@
          </vbox>
          <arrowscrollbox class="menupopup-arrowscrollbox" flex="1"
                          orient="vertical" smoothscroll="false"
                          part="arrowscrollbox content">
                          part="arrowscrollbox">
            <html:slot/>
          </arrowscrollbox>
        </box>
Loading