Commit f9a6fc75 authored by Omar Morsi's avatar Omar Morsi Committed by moz-wptsync-bot
Browse files

Bug 1721623 [wpt PR 29733] - Revert "[BreakoutBox] Remove control signals", a=testonly 

Automatic update from web-platform-tests
Revert "[BreakoutBox] Remove control signals"

This reverts commit d3e3ffc0b381bf75918602d95a1fbf300b0b3cd2.

Reason for revert: win-archive-rel build is failing in compile step with error  clang-cl: error: no such file or directory: ‘gen/third_party/blink/renderer/bindings/modules/v8/v8_media_stream_track_signal.cc’ and this CL deletes a file with a similar name.
failing bots:
- https://ci.chromium.org/ui/p/chromium/builders/ci/win-archive-rel/25334/overview
- https://ci.chromium.org/ui/p/chromium/builders/ci/mac-arm64-archive-rel/1527/overview
Original change's description:
> [BreakoutBox] Remove control signals
>
> Bug: 1231028
> Change-Id: I9047003c75fdc3f7ca8042917057c8d0ed97b1e9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3039183


> Commit-Queue: Tony Herre <toprice@chromium.org>
> Auto-Submit: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: default avatarTony Herre <toprice@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#903828}

Bug: 1231028
Change-Id: If475d3554aa38ee66e3761621779e60208482e5b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3041475


Reviewed-by: default avatarAlexander Hendrich <hendrich@chromium.org>
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Auto-Submit: Omar Morsi <omorsi@google.com>
Owners-Override: Omar Morsi <omorsi@google.com>
Cr-Commit-Position: refs/heads/master@{#903840}

--

wpt-commits: 2449eda7ea113722e54b14b30cf5648eacd7ee88
wpt-pr: 29733
parent 7e354f11

testing/web-platform/tests/mediacapture-insertable-streams/MediaStreamTrackGenerator-audio.https.html

+31 −1
Original line number Diff line number Diff line
@@ -51,6 +51,23 @@ 
      t.add_cleanup(() => generator.stop());

    }, "Tests that creating a Audio MediaStreamTrackGenerator works as expected");



    promise_test(async t => {

      const capturedStream = await navigator.mediaDevices.getUserMedia({ audio: true });

      assert_equals(capturedStream.getAudioTracks().length, 1);

      const upstreamTrack = capturedStream.getAudioTracks()[0];

      t.add_cleanup(() => upstreamTrack.stop());



      const generator = new MediaStreamTrackGenerator({ signalTarget: upstreamTrack, kind: "audio" });

      t.add_cleanup(() => generator.stop());



      const writer = generator.writable.getWriter();

      const data = makeAudioData(1);

      await writer.write(data);



      assert_equals(generator.kind, "audio");

      assert_equals(generator.readyState, "live");

    }, "Tests that creating an Audio MediaStreamTrackGenerator with a signal target works as expected");



    promise_test(async t => {

      assert_throws_js(TypeError, () => { new MediaStreamTrackGenerator({ kind: "invalid kind" }) });

    }, "Creating Generator with an invalid kind throws");
@@ -61,9 +78,22 @@ 
      const upstreamTrack = capturedStream.getAudioTracks()[0];

      t.add_cleanup(() => upstreamTrack.stop());



      assert_throws_js(TypeError, () => { new MediaStreamTrackGenerator() });

      assert_throws_js(TypeError, () => { new MediaStreamTrackGenerator({ signalTarget: upstreamTrack }) });

    }, "Creating Generator with a missing kind throws");



    promise_test(async t => {

      const capturedStream = await navigator.mediaDevices.getUserMedia({ audio: true });

      assert_equals(capturedStream.getAudioTracks().length, 1);

      const upstreamTrack = capturedStream.getAudioTracks()[0];

      t.add_cleanup(() => upstreamTrack.stop());



      assert_throws_js(TypeError, () => { new MediaStreamTrackGenerator({ signalTarget: upstreamTrack, kind: "video" }) });

    }, "Creating Generator with mismatched kinds throws");



    promise_test(async t => {

      assert_throws_js(TypeError, () => { new MediaStreamTrackGenerator({ signalTarget: "IamNotATrack" }) });

    }, "Creating Generator with invalid signalTarget throws");



    promise_test(async t => {

      const generator = new MediaStreamTrackGenerator({ kind: "video" });

      t.add_cleanup(() => generator.stop());

testing/web-platform/tests/mediacapture-insertable-streams/MediaStreamTrackGenerator-video.https.html

+18 −0
Original line number Diff line number Diff line
@@ -197,6 +197,24 @@ 
      assert_throws_dom("InvalidStateError", () => frame.clone(), "VideoFrame wasn't destroyed on write.");

    }, "Tests that VideoFrames are destroyed on write.");



    promise_test(async t => {

      const capturedStream = await navigator.mediaDevices.getUserMedia({ video: true });

      assert_equals(capturedStream.getVideoTracks().length, 1);

      const upstreamTrack = capturedStream.getVideoTracks()[0];

      t.add_cleanup(() => upstreamTrack.stop());



      const generator = new MediaStreamTrackGenerator({ signalTarget: upstreamTrack, kind: "video" });

      t.add_cleanup(() => generator.stop());



      const writer = generator.writable.getWriter();

      const frame = makeVideoFrame(1);

      await writer.write(frame);



      assert_equals(generator.kind, "video");

      assert_equals(generator.readyState, "live");

    }, "Tests that creating a Video MediaStreamTrackGenerator with a signal target works as expected");





    promise_test(async t => {

      const generator = new MediaStreamTrackGenerator("audio");

      t.add_cleanup(() => generator.stop());