Commit fa5d4cca authored by Andi-Bogdan Postelnicu's avatar Andi-Bogdan Postelnicu
Browse files

Bug 1660405 - Move away from mozilla::IsFinite in favor of std::isfinite. r=sergesanspaille 

Differential Revision: https://phabricator.services.mozilla.com/D173036
parent 10f49d41

dom/animation/AnimationEffect.cpp

+3 −3
Original line number Diff line number Diff line
@@ -183,7 +183,7 @@ ComputedTiming AnimationEffect::GetComputedTimingAt( 
  }



  // Factor in iteration start offset.

  if (IsFinite(overallProgress)) {

  if (std::isfinite(overallProgress)) {

    overallProgress += result.mIterationStart;

  }
@@ -200,7 +200,7 @@ ComputedTiming AnimationEffect::GetComputedTimingAt( 
  // Convert the overall progress to a fraction of a single iteration--the

  // simply iteration progress.

  // https://drafts.csswg.org/web-animations/#simple-iteration-progress

  double progress = IsFinite(overallProgress)

  double progress = std::isfinite(overallProgress)

                        ? fmod(overallProgress, 1.0)

                        : fmod(result.mIterationStart, 1.0);
@@ -260,7 +260,7 @@ ComputedTiming AnimationEffect::GetComputedTimingAt( 
    progress = fn->At(progress, result.mBeforeFlag);

  }



  MOZ_ASSERT(IsFinite(progress), "Progress value should be finite");

  MOZ_ASSERT(std::isfinite(progress), "Progress value should be finite");

  result.mProgress.SetValue(progress);

  return result;

}

dom/base/DOMMatrix.cpp

+1 −1
Original line number Diff line number Diff line
@@ -512,7 +512,7 @@ void DOMMatrixReadOnly::Stringify(nsAString& aResult, ErrorResult& aRv) { 
  nsAutoString matrixStr;

  auto AppendDouble = [&aRv, &cbuf, &matrixStr](double d,

                                                bool isLastItem = false) {

    if (!mozilla::IsFinite(d)) {

    if (!std::isfinite(d)) {

      aRv.ThrowInvalidStateError(

          "Matrix with a non-finite element cannot be stringified.");

      return false;

dom/base/nsContentUtils.h

+13 −13
Original line number Diff line number Diff line
@@ -3608,27 +3608,27 @@ class TreeOrderComparator { 
 * series is not finite.

 */

#define NS_ENSURE_FINITE(f, rv) \

  if (!mozilla::IsFinite(f)) {  \

  if (!std::isfinite(f)) {      \

    return (rv);                \

  }



#define NS_ENSURE_FINITE2(f1, f2, rv) \

  if (!mozilla::IsFinite((f1) + (f2))) { \

  if (!std::isfinite((f1) + (f2))) {  \

    return (rv);                      \

  }



#define NS_ENSURE_FINITE4(f1, f2, f3, f4, rv)      \

  if (!mozilla::IsFinite((f1) + (f2) + (f3) + (f4))) { \

  if (!std::isfinite((f1) + (f2) + (f3) + (f4))) { \

    return (rv);                                   \

  }



#define NS_ENSURE_FINITE5(f1, f2, f3, f4, f5, rv)         \

  if (!mozilla::IsFinite((f1) + (f2) + (f3) + (f4) + (f5))) { \

  if (!std::isfinite((f1) + (f2) + (f3) + (f4) + (f5))) { \

    return (rv);                                          \

  }



#define NS_ENSURE_FINITE6(f1, f2, f3, f4, f5, f6, rv)            \

  if (!mozilla::IsFinite((f1) + (f2) + (f3) + (f4) + (f5) + (f6))) { \

  if (!std::isfinite((f1) + (f2) + (f3) + (f4) + (f5) + (f6))) { \

    return (rv);                                                 \

  }

dom/bindings/Codegen.py

+1 −1
Original line number Diff line number Diff line
@@ -7354,7 +7354,7 @@ def getJSToNativeConversionInfo( 
        template = template.rstrip()

        template += fill(

            """

             else if (!mozilla::IsFinite(${readLoc})) {

             else if (!std::isfinite(${readLoc})) {

              $*{nonFiniteCode}

            }

            """,

dom/bindings/PrimitiveConversions.h

+2 −2
Original line number Diff line number Diff line
@@ -198,7 +198,7 @@ inline bool PrimitiveConversionTraits_EnforceRange( 
  static_assert(std::numeric_limits<T>::is_integer,

                "This can only be applied to integers!");



  if (!mozilla::IsFinite(d)) {

  if (!std::isfinite(d)) {

    return cx.ThrowErrorMessage<MSG_ENFORCE_RANGE_NON_FINITE>(

        sourceDescription, TypeName<T>::value());

  }
@@ -242,7 +242,7 @@ inline bool PrimitiveConversionTraits_Clamp(JSContext* cx, 
    return true;

  }



  MOZ_ASSERT(mozilla::IsFinite(d));

  MOZ_ASSERT(std::isfinite(d));



  // Banker's rounding (round ties towards even).

  // We move away from 0 by 0.5f and then truncate.  That gets us the right