GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  1. 12 Jun, 2020 1 commit
  2. 05 Jun, 2020 1 commit
  3. 29 May, 2020 2 commits
    • Philipp Winter's avatar
      Don't assume that request has "command" key. · b3de2e35
      Philipp Winter authored
      If GetTor deals with an autoresponder, it returns an empty request,
      which is then passed to parse_callback, which raises a KeyError because
      of request["command"]:
      
      2020-05-29 19:04:43+0000 [email parser] Error while parsing email content: [Failure instance: Traceback: <class 'KeyError'>: 'command'
      	/usr/lib/python3/dist-packages/twisted/internet/defer.py:311:addCallbacks
      	/usr/lib/python3/dist-packages/twisted/internet/defer.py:654:_runCallbacks
      	/usr/lib/python3/dist-packages/twisted/internet/defer.py:1613:unwindGenerator
      	/usr/lib/python3/dist-packages/twisted/internet/defer.py:1529:_cancellableInlineCallbacks
      	--- <exception caught here> ---
      	/usr/lib/python3/dist-packages/twisted/internet/defer.py:1418:_inlineCallbacks
      	/srv/gettor.torproject.org/home/gettor/gettor/parse/email.py:256:parse_callback
      	].
      
      This is a fixup of: <https://bugs.torproject.org/34286>
      b3de2e35
    • Cecylia Bocovich's avatar
      Check to see if email is from an autoresponder · 012ef1a4
      Cecylia Bocovich authored
      This checks to see if an incoming request is from a known autoresponder.
      GetTor can get into infinite loops with itself or postmaster addresses
      (Bug #34286)
      012ef1a4
  4. 22 May, 2020 1 commit
    • Cecylia Bocovich's avatar
      Ignore emails from Mail Delivery System · b78bc3ff
      Cecylia Bocovich authored
      This ignores emails with the username "MAILER-DAEMON", a common email
      for mail delivery systems. The goal of this is to avoid getting into a
      loop with mail delivery system autoresponders after a bounced email.
      b78bc3ff
  5. 04 May, 2020 2 commits
  6. 29 Apr, 2020 2 commits
    • Cecylia Bocovich's avatar
      Delete service instance during shutdown · 21645db1
      Cecylia Bocovich authored
      Before we were calling a non-existent shutdown function. These instances
      already have __del__ functions so we can just call those instead.
      21645db1
    • Cecylia Bocovich's avatar
      Refactor to dry out sendmail · 390120a0
      Cecylia Bocovich authored
      Instead of processing link and help requests separately, we can process
      them together and use the command to determine the different subject and
      body messages.
      
      Removed unused code and simplified database command.
      390120a0
  7. 27 Apr, 2020 1 commit
  8. 13 Apr, 2020 6 commits
  9. 18 Mar, 2020 4 commits
  10. 12 Mar, 2020 3 commits
    • Cecylia Bocovich's avatar
      Make locale parsing less eager · 829fa9fb
      Cecylia Bocovich authored
      This will make the locale parsing more restrictive so that, for example,
      sending "i like fries" will not result in the locale "fr".
      829fa9fb
    • Cecylia Bocovich's avatar
      Add more test cases for different email styles · c8e385ba
      Cecylia Bocovich authored
      teor mentioned in ticket #23225 that some clients will top-post replies
      without quoting the the text. This commit adds a test case for that.
      Since the command detector is greedy, gettor parses the reply first.
      
      Also added a test for bottom-posting.
      c8e385ba
    • Cecylia Bocovich's avatar
      Ensure replies to the help message will work · 0cd6443c
      Cecylia Bocovich authored
      This commit makes some changes and adds some tests to ensure that
      valid replies to the gettor help message will contain links.
      Non-valid replies should still return the GetTor help message.
      0cd6443c
  11. 11 Mar, 2020 1 commit
  12. 06 Mar, 2020 1 commit
    • Cecylia Bocovich's avatar
      Always reply to gettor emails · 61afa2c5
      Cecylia Bocovich authored
      This fixes a bug where improperly formatted emails were not receiving
      gettor replies. We should always reply to emails and default to sending
      a help message if the request was invalid.
      
      This also prioritizes sending links if both a valid links request and
      the word help were sent. Several tests were added.
      61afa2c5
  13. 19 Feb, 2020 4 commits
  14. 13 Feb, 2020 1 commit
  15. 08 Feb, 2020 3 commits
  16. 31 Jan, 2020 2 commits
  17. 27 Jan, 2020 3 commits
    • Cecylia Bocovich's avatar
      Make locale parser more robust · 277ba71b
      Cecylia Bocovich authored
      This change expands the locale parse to have the following properties:
      - if only the language code is given, choses the regionalization that
      occurs first in the locale list (e.g., "en" --> "en-US"
      - if regionalization for the language is *not* present, choses the
      generalized language or a different regionalization (e.g. "pt-PT" -->
      "pt-BR")
      - parses both the subject and body looking for the most specific
      regionalization
      - defaults to en-US if no available language is found
      277ba71b
    • Cecylia Bocovich's avatar
      Refactor email keyword parser · 4fa4d636
      Cecylia Bocovich authored
      This commit refactors build_request to prevent duplicate code. It
      also moves the platforms definition to the parser constructor.
      4fa4d636
    • Cecylia Bocovich's avatar
      Modified email parser to get locales from db · 187e27da
      Cecylia Bocovich authored
      Before we were conflating the locales for the tor browser binaries with
      the available locale for gettor email body localizations. This patch
      checks our links database for available locales.
      187e27da
  18. 23 Jan, 2020 2 commits