Commit 274ef64f authored by Mike Conley's avatar Mike Conley
Browse files

Bug 1752593 - Poll for TopSitesFeed in Talos getInfo shutdown routine instead... 

Bug 1752593 - Poll for TopSitesFeed in Talos getInfo shutdown routine instead of assuming it exists. r=perftest-reviewers,sparky

The TopSitesFeed instance might actually not exist yet, since Store initializes asynchronously.
There doesn't appear to be a great way to actually observe the creation of the TopSitesFeed
via observer notifications, events, or other exposed properties, so we'll poll for now.

Differential Revision: https://phabricator.services.mozilla.com/D137463
parent c32559a4

testing/talos/talos/talos-powers/api.js

+18 −3
Original line number Diff line number Diff line
@@ -13,6 +13,8 @@ XPCOMUtils.defineLazyModuleGetters(this, { 
  BrowserWindowTracker: "resource:///modules/BrowserWindowTracker.jsm",

  OS: "resource://gre/modules/osfile.jsm",

  PerTestCoverageUtils: "resource://testing-common/PerTestCoverageUtils.jsm",

  SessionStore: "resource:///modules/sessionstore/SessionStore.jsm",

  setTimeout: "resource://gre/modules/Timer.jsm",

});



XPCOMUtils.defineLazyServiceGetter(
@@ -292,14 +294,27 @@ TalosPowersService.prototype = { 
      // about:home startup cache on shutdown, which causes that test

      // to break periodically.

      AboutNewTab.onBrowserReady();

      let feed = AboutNewTab.activityStream.store.feeds.get(

      // There aren't currently any easily observable notifications or

      // events to let us know when the feed is ready, so we'll just poll

      // for now.

      let pollForFeed = async function() {

        let foundFeed = AboutNewTab.activityStream.store.feeds.get(

          "feeds.system.topsites"

        );

        if (!foundFeed) {

          await new Promise(resolve => setTimeout(resolve, 500));

          return pollForFeed();

        }

        return foundFeed;

      };

      let feed = await pollForFeed();

      await feed._contile.refresh();

      await feed.refresh({ broadcast: true });

      await AboutHomeStartupCache.cacheNow();

    }



    await SessionStore.promiseAllWindowsRestored;



    // Check to see if the top-most browser window still needs to fire its

    // idle tasks notification. If so, we'll wait for it before shutting

    // down, since some caching that can influence future runs in this profile