Commit 2ac8f2e7 authored by stransky's avatar stransky
Browse files

Bug 1787182 [Linux] Don't fire glxtest process unless we know we really want to run r=emilio 

Right now we fire glxtest on every Firefox start, even if we going to update, restart or ping running remote instance.
When we're running on system with broken/unstable gfx drivers (drivers/glx freezes or crashes) every such action is delayed or coredumps are generated on systems.

In this patch we launch glx test proces later if we know we need it.

Depends on D168650

Differential Revision: https://phabricator.services.mozilla.com/D168651
parent e0aa2e43

toolkit/xre/nsAppRunner.cpp

+4 −11
Original line number Diff line number Diff line
@@ -3949,17 +3949,6 @@ int XREMain::XRE_mainInit(bool* aExitFlag) { 


  mozilla::startup::IncreaseDescriptorLimits();



#ifdef USE_GLX_TEST

  // bug 639842 - it's very important to fire this process BEFORE we set up

  // error handling. indeed, this process is expected to be crashy, and we

  // don't want the user to see its crashes. That's the whole reason for

  // doing this in a separate process.

  //

  // This call will cause a fork and the fork will terminate itself separately

  // from the usual shutdown sequence

  fire_glxtest_process();

#endif



  SetupErrorHandling(gArgv[0]);



#ifdef CAIRO_HAS_DWRITE_FONT
@@ -5121,6 +5110,10 @@ int XREMain::XRE_mainStartup(bool* aExitFlag) { 
  // Flush any pending page load events.

  mozilla::glean_pings::Pageload.Submit("startup"_ns);



#ifdef USE_GLX_TEST

  fire_glxtest_process();

#endif



  return 0;

}