Commit a516af2a authored by Emilio Cobos Álvarez's avatar Emilio Cobos Álvarez
Browse files

Bug 1822453 - Tweak settings dialog list styles. r=settings-reviewers,mconley 

This is not a new regression: that min-height which effectively prevents
shrinking of this list has been there since ~forever, so probably this
broke, if it broke at all, when we enabled modern flexbox emulation of
these dialogs.

Now that XUL can shrink this gets us the behavior we want (default to
18em, but allow both growing and shrinking).

Fix the sites list as well to behave similarly.

Differential Revision: https://phabricator.services.mozilla.com/D173034
parent a48b170a

browser/components/preferences/dialogs/permissions.xhtml

+1 −1
Original line number Diff line number Diff line
@@ -66,7 +66,7 @@ 
               data-isCurrentSortCol="true"

               onclick="gPermissionManager.buildPermissionsList(event.target);"/>

    </listheader>

    <richlistbox id="permissionsBox" flex="1" selected="false"

    <richlistbox id="permissionsBox" selected="false"

                 onkeypress="gPermissionManager.onPermissionKeyPress(event);"

                 onselect="gPermissionManager.onPermissionSelect();"/>

  </vbox>

browser/components/preferences/dialogs/siteDataSettings.xhtml

+1 −1
Original line number Diff line number Diff line
@@ -48,7 +48,7 @@ 
      <treecol style="flex: 2 2 auto; width: 50px" data-l10n-id="site-data-column-storage" id="usageCol" data-isCurrentSortCol="true"/>

      <treecol style="flex: 2 2 auto; width: 50px" data-l10n-id="site-data-column-last-used" id="lastAccessedCol" />

    </listheader>

    <richlistbox seltype="multiple" id="sitesList" orient="vertical" flex="1"/>

    <richlistbox seltype="multiple" id="sitesList" orient="vertical"/>

  </vbox>



  <hbox align="start">

browser/components/preferences/dialogs/sitePermissions.css

+2 −2
Original line number Diff line number Diff line
@@ -10,8 +10,8 @@ hbox.website-status { 
}



#permissionsBox {

  min-height: 18em;

  contain: size;

  flex: 1 auto;

  height: 18em;

}



#siteCol,

browser/themes/shared/preferences/siteDataSettings.css

+1 −0
Original line number Diff line number Diff line
@@ -6,6 +6,7 @@ 
 * Site Data - Settings dialog

 */

#sitesList {

  flex: 1 auto;

  height: 20em;

}