Commit f79fdd39 authored by James Teh's avatar James Teh
Browse files

Bug 1833313: Remove all remaining a11y cache checks and non-caching code... 

Bug 1833313: Remove all remaining a11y cache checks and non-caching code except for Mac specific bits. r=morgan,geckoview-reviewers,calu

Differential Revision: https://phabricator.services.mozilla.com/D178146
parent c8a016a7

accessible/android/SessionAccessibility.cpp

+0 −4
Original line number Diff line number Diff line
@@ -115,8 +115,6 @@ void SessionAccessibility::Init() { 
  Settings::Init();

}



bool SessionAccessibility::IsCacheEnabled() { return a11y::IsCacheActive(); }



void SessionAccessibility::GetNodeInfo(int32_t aID,

                                       mozilla::jni::Object::Param aNodeInfo) {

  MOZ_ASSERT(AndroidBridge::IsJavaUiThread());
@@ -144,7 +142,6 @@ void SessionAccessibility::GetNodeInfo(int32_t aID, 


int SessionAccessibility::GetNodeClassName(int32_t aID) {

  MOZ_ASSERT(AndroidBridge::IsJavaUiThread());

  MOZ_ASSERT(IsCacheEnabled(), "Cache is enabled");

  ReleasableMonitorAutoLock mal(nsAccessibilityService::GetAndroidMonitor());

  int32_t classNameEnum = java::SessionAccessibility::CLASSNAME_VIEW;

  RefPtr<SessionAccessibility> self(this);
@@ -180,7 +177,6 @@ void SessionAccessibility::Click(int32_t aID) { 


bool SessionAccessibility::Pivot(int32_t aID, int32_t aGranularity,

                                 bool aForward, bool aInclusive) {

  MOZ_ASSERT(IsCacheEnabled(), "Cache is enabled");

  MOZ_ASSERT(AndroidBridge::IsJavaUiThread());

  MonitorAutoLock mal(nsAccessibilityService::GetAndroidMonitor());

  RefPtr<SessionAccessibility> self(this);

accessible/android/SessionAccessibility.h

+0 −1
Original line number Diff line number Diff line
@@ -51,7 +51,6 @@ class SessionAccessibility final 
  // Native implementations

  using Base::AttachNative;

  using Base::DisposeNative;

  bool IsCacheEnabled();

  void GetNodeInfo(int32_t aID, mozilla::jni::Object::Param aNodeInfo);

  int GetNodeClassName(int32_t aID);

  void SetText(int32_t aID, jni::String::Param aText);

accessible/base/AccIterator.cpp

+0 −7
Original line number Diff line number Diff line
@@ -12,7 +12,6 @@ 
#include "mozilla/a11y/DocAccessibleParent.h"

#include "mozilla/dom/DocumentOrShadowRoot.h"

#include "mozilla/dom/HTMLLabelElement.h"

#include "nsAccessibilityService.h"



using namespace mozilla;

using namespace mozilla::a11y;
@@ -351,12 +350,6 @@ LocalAccessible* XULTreeItemIterator::Next() { 
// RemoteAccIterator

////////////////////////////////////////////////////////////////////////////////



RemoteAccIterator::RemoteAccIterator(nsTArray<uint64_t>&& aIds,

                                     DocAccessibleParent* aDoc)

    : mOwnedIds(std::move(aIds)), mIds(mOwnedIds), mDoc(aDoc), mIndex(0) {

  MOZ_ASSERT(!a11y::IsCacheActive());

}



Accessible* RemoteAccIterator::Next() {

  while (mIndex < mIds.Length()) {

    uint64_t id = mIds[mIndex++];

accessible/base/AccIterator.h

+0 −9
Original line number Diff line number Diff line
@@ -312,20 +312,11 @@ class RemoteAccIterator : public AccIterable { 
  RemoteAccIterator(const nsTArray<uint64_t>& aIds, DocAccessibleParent* aDoc)

      : mIds(aIds), mDoc(aDoc), mIndex(0) {}



  /**

   * Construct with an array moved from somewhere else. In this case, this

   * RemoteAccIterator takes ownership of the array. This should be used, for

   * example, when using sync IPC to retrieve relations.

   */

  RemoteAccIterator(nsTArray<uint64_t>&& aIds, DocAccessibleParent* aDoc);



  virtual ~RemoteAccIterator() = default;



  virtual Accessible* Next() override;



 private:

  // Used when ownership of the array is transferred to this instance.

  nsTArray<uint64_t> mOwnedIds;

  const nsTArray<uint64_t>& mIds;

  DocAccessibleParent* mDoc;

  uint32_t mIndex;

accessible/base/EventQueue.cpp

+2 −3
Original line number Diff line number Diff line
@@ -9,7 +9,6 @@ 
#include "nsEventShell.h"

#include "DocAccessible.h"

#include "DocAccessibleChild.h"

#include "nsAccessibilityService.h"

#include "nsTextEquivUtils.h"

#ifdef A11Y_LOG

#  include "Logging.h"
@@ -352,7 +351,7 @@ void EventQueue::ProcessEventQueue() { 
    if (!target || target->IsDefunct()) continue;



    // Collect select changes

    if (IPCAccessibilityActive() && a11y::IsCacheActive()) {

    if (IPCAccessibilityActive()) {

      if ((event->mEventRule == AccEvent::eDoNotEmit &&

           (eventType == nsIAccessibleEvent::EVENT_SELECTION_ADD ||

            eventType == nsIAccessibleEvent::EVENT_SELECTION_REMOVE ||
@@ -417,7 +416,7 @@ void EventQueue::ProcessEventQueue() { 
    if (!mDocument) return;

  }



  if (mDocument && IPCAccessibilityActive() && a11y::IsCacheActive() &&

  if (mDocument && IPCAccessibilityActive() &&

      (!selectedIDs.IsEmpty() || !unselectedIDs.IsEmpty())) {

    DocAccessibleChild* ipcDoc = mDocument->IPCDoc();

    ipcDoc->SendSelectedAccessiblesChanged(selectedIDs, unselectedIDs);