Bug 1834115 - migrate newtab/lib JSMs that do not import modules to ESMs r=Standard8,fxview-reviewers,omc-reviewers,aminomancer,sfoster

Differential Revision: https://phabricator.services.mozilla.com/D178568

This patch removes the vast majority of OS.File and support code. A few things remain:

- The nsIOSFileConstantsService still exists, but the path related constants
  (OS.Constants.Path.*) are no longer added to the OS object. The plan is to
  replace this with a proper service e.g. Services.osConstants or similar) in
  bug 1786885.
- There is still support for OS.File errors in ErrorSanitizer, which will be
  removed in bug 1775167.
- The OS.File to IOUtils migration guide will be rewritten as general IOUtils
  documentation in bug 1830097.
- dom/base/Document.cpp has a workaround for not loading osfile.jsm at startup,
  which may want to be reconsidered in bug 1830100.

So long, and thanks for all the I/O.

Differential Revision: https://phabricator.services.mozilla.com/D176543

Backed out changeset 987d013caf11 (bug 1776480) for causing xpc failures in toolkit/components/extensions/test/xpcshell/test_ext_downloads_download.js CLOSED TREE

This patch removes the vast majority of OS.File and support code. A few things remain:

- The nsIOSFileConstantsService still exists, but the path related constants
  (OS.Constants.Path.*) are no longer added to the OS object. The plan is to
  replace this with a proper service e.g. Services.osConstants or similar) in
  bug 1786885.
- There is still support for OS.File errors in ErrorSanitizer, which will be
  removed in bug 1775167.
- The OS.File to IOUtils migration guide will be rewritten as general IOUtils
  documentation in bug 1830097.
- dom/base/Document.cpp has a workaround for not loading osfile.jsm at startup,
  which may want to be reconsidered in bug 1830100.

So long, and thanks for all the I/O.

Differential Revision: https://phabricator.services.mozilla.com/D176543

Bug 1830816 - Convert JSMs in browser/tools/mozscreenshots/mozscreenshots/extension to ESMs. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D177101

Backed out changeset 73b7fefcfc45 (bug 1830816) for causing mochitest failures on browser_controlCenter.js. CLOSED TREE

Bug 1830816 - Convert JSMs in browser/tools/mozscreenshots/mozscreenshots/extension to ESMs. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D177101

The test was getting stuck because it was expecting a favicon.ico
request that never happened. The test logic was copied from
test_ext_webrequest_filter.html which suffers from exactly the same
issue. Since the favicon.ico test was meant to serve as a regression
test, this patch fixes only one of the two tests.

This patch also changes "http" to "https" in file_simple_xhr.html to get
the test to run successfully with the http3 test configuration, as
explained at https://bugzilla.mozilla.org/show_bug.cgi?id=1482983#c71

Differential Revision: https://phabricator.services.mozilla.com/D174505

Backed out changeset 3d766d94945d (bug 1776480) for causing multiple xpcshell and bc failures CLOSED TREE

This patch removes the vast majority of OS.File and support code. A few things remain:

- The nsIOSFileConstantsService still exists, but the path related constants
  (OS.Constants.Path.*) are no longer added to the OS object. The plan is to
  replace this with a proper service e.g. Services.osConstants or similar) in
  bug 1786885.
- There is still support for OS.File errors in ErrorSanitizer, which will be
  removed in bug 1775167.
- The OS.File to IOUtils migration guide will be rewritten as general IOUtils
  documentation in bug 1830097.
- dom/base/Document.cpp has a workaround for not loading osfile.jsm at startup,
  which may want to be reconsidered in bug 1830100.

So long, and thanks for all the I/O.

Differential Revision: https://phabricator.services.mozilla.com/D176543

This patch removes the vast majority of OS.File and support code. A few things remain:

- The nsIOSFileConstantsService still exists, but the path related constants
  (OS.Constants.Path.*) are no longer added to the OS object. The plan is to
  replace this with a proper service e.g. Services.osConstants or similar) in
  bug 1786885.
- There is still support for OS.File errors in ErrorSanitizer, which will be
  removed in bug 1775167.
- The OS.File to IOUtils migration guide will be rewritten as general IOUtils
  documentation in bug 1830097.
- dom/base/Document.cpp has a workaround for not loading osfile.jsm at startup,
  which may want to be reconsidered in bug 1830100.

So long, and thanks for all the I/O.

Differential Revision: https://phabricator.services.mozilla.com/D176543

Differential Revision: https://phabricator.services.mozilla.com/D174861

Bug 1826702 - Convert PermissionTestUtils to an ES module. r=permissions-reviewers,settings-reviewers,media-playback-reviewers,pbz,padenot

Differential Revision: https://phabricator.services.mozilla.com/D174846

Depends on D174739

Differential Revision: https://phabricator.services.mozilla.com/D174718

Bug 1824173 - Enable ESLint configuration valid-jsdocs across the tree, disabling for currently failing locations. r=mossop,webcompat-reviewers,extension-reviewers,credential-management-reviewers,denschub,dimi,robwu

Depends on D173450

Differential Revision: https://phabricator.services.mozilla.com/D173451

.sys.mjs will be handled in a future dependency of bug 1575506.

Differential Revision: https://phabricator.services.mozilla.com/D169464

Differential Revision: https://phabricator.services.mozilla.com/D169513

This also converts certDecoder.jsm to an ES module (as certDecoder.mjs) and
updates all uses of it.

Differential Revision: https://phabricator.services.mozilla.com/D167466

Backed out changeset 3ef0fe45b191 (bug 1811633)
Backed out changeset 92a7ec78a4ce (bug 1811633)

This also converts certDecoder.jsm to an ES module (as certDecoder.mjs) and
updates all uses of it.

Differential Revision: https://phabricator.services.mozilla.com/D167466

Differential Revision: https://phabricator.services.mozilla.com/D167285

Differential Revision: https://phabricator.services.mozilla.com/D167284

Differential Revision: https://phabricator.services.mozilla.com/D167283

Differential Revision: https://phabricator.services.mozilla.com/D167281

Differential Revision: https://phabricator.services.mozilla.com/D167279

Backed out changeset 715821104ffa (bug 1811278)
Backed out changeset 6f116715687d (bug 1811278)
Backed out changeset 16e69d940e3f (bug 1811278)
Backed out changeset 9dc0451ca213 (bug 1811278)
Backed out changeset 9f60a414e711 (bug 1811278)

Differential Revision: https://phabricator.services.mozilla.com/D167285

Differential Revision: https://phabricator.services.mozilla.com/D167284

Differential Revision: https://phabricator.services.mozilla.com/D167283

Differential Revision: https://phabricator.services.mozilla.com/D167281

Differential Revision: https://phabricator.services.mozilla.com/D167279

Bug 1811796 - Automatically replace Cu.reportError with console.error (most of toolkit). r=mossop,credential-management-reviewers,dimi

Depends on D167518

Differential Revision: https://phabricator.services.mozilla.com/D167519

Bug 1811334 - Automatically replace Cu.reportError with console.error (most of browser/components). r=settings-reviewers,mconley

Differential Revision: https://phabricator.services.mozilla.com/D167297

Bug 1810877 - Automatically replace Cu.reportError with console.error (browser/extensions/report-site-issue/). r=webcompat-reviewers,twisniewski

Depends on D167095

Differential Revision: https://phabricator.services.mozilla.com/D167096

Bug 1810877 - Automatically replace Cu.reportError with console.error (browser/extensions/search-detection/). r=willdurand

Differential Revision: https://phabricator.services.mozilla.com/D167095

Differential Revision: https://phabricator.services.mozilla.com/D165941

Differential Revision: https://phabricator.services.mozilla.com/D165067

Bug 1808289 - Automatically replace Cu.reportError with console.error (browser/themes, browser/modules). r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D165848

Bug 1808289 - Automatically replace Cu.reportError calls with console.error (BrowserGlue.sys.mjs). r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D165847