GitLab

On torspec!40, Mike says:

    I don't think there is a practical difference here. As per
    Section 2.4.5, if 60 seconds is not enough and causes the
    liveness test to fail due to too many timeouts, we will double
    the initial timeout.

This makes our behavior the same as C tor.

The C Tor implementation doesn't do this, and Mike says:

   I think it is a reasonable enough assumption that if Tor has
   restarted, this kind data is no longer fresh enough to be
   accurate for this purpose. This is also only 20 circuits here,
   and typical timeouts are now around 1-2 seconds or less.. So a
   restarted client with a timeout that is too low for a new
   internet connection will figure this out pretty quickly. I think
   that is OK.

(from torspec!40)

Now that we have const generics, we can use them.  We can also avoid
an extra clone in the implementation for [u8; N].

Nothing in our codebase requires that we use Reader or Writer on a
GenericArray holding anything other than u8, so I've switched back
to the more efficient implementation there.

I've added a fuzzer case for the new method, but apparently rustc nightly isn't working too
well with fuzzers for me; I'm going to try it tomorrow.

(The nightly version of clippy now includes macros for its
missing_docs_in_private_items lint.)

build takes about 23 minutes, it's quiet long for something that is
usefull mostly on releases

Linux hash   : c024778da162cda77869c46d162729d012a7758bee973bc83fa78c964d080903
Windows hash : e97e171740b889b7e3722b79c3763177174baac7fa34a5c3615c999298e1bc48

It looks like there was a directory here I didn't update when I
moved all the crates into crates/

This will cause some pain for now, but now is really the best time
to do this kind of thing.

Instead of loading it with expect() calls, make a new function that
returns a Result, and call expect() only once.

(This is what we do for lock poisoning everywhere else.)

The most frequent changes are:

   - Rewording messages about poisoned locks
   - Correcting some error types

Replace the trace config file option with a more flexible trace_filter
and expose the same via the ARTI_LOG environment variable.
If ARTI_LOG is set it will override the setting in the config file.

Example:

ARTI_LOG="info,tor_proto::channel=trace" ./target/debug/arti

The syntax is described here
https://docs.rs/tracing-subscriber/0.2.20/tracing_subscriber/filter/struct.EnvFilter.html#directives

sha256: 7f190568fa05f71ad356dc56a7a9725a4be18e5e40d6880f469e22981a18edd7

> Note, while `cargo fmt` doesn't complain I think this section could be
> prettier. Also it may be a good idea to have tests double-check that future
> changes don't cause a panic condition.

And convert some `add_or_port` calls to use `SocketAddr` instead of
parse + unwrap on strings.

> Note, this last change is only for IPv4 addresses, for now, and only
> within tests.

see https://github.com/rusqlite/rusqlite/issues/914

sha256: 684ebc4b8c270fc63beba185f6c54ceeb98734f13aa7aeca9b64acb33432a21c

and make builds reproducible
sha256sum: f141c54929a43a31b9ed6b529f6f863aace87f7406818b2f8ffe2b7a5e2803fb