1. 19 Jul, 2021 10 commits
  2. 18 Jul, 2021 2 commits
  3. 13 Jul, 2021 1 commit
  4. 08 Jul, 2021 6 commits
  5. 07 Jul, 2021 2 commits
  6. 24 Jun, 2021 8 commits
  7. 23 Jun, 2021 1 commit
  8. 19 Jun, 2021 1 commit
    • Cecylia Bocovich's avatar
      Store net.Addr in clientIDAddrMap · 6634f2be
      Cecylia Bocovich authored
      This fixes a stats collection bug where we were converting client
      addresses between a string and net.Addr using the clientAddr function
      multiple times, resulting in an empty string for all addresses.
      6634f2be
  9. 14 Jun, 2021 1 commit
  10. 07 Jun, 2021 1 commit
  11. 02 Jun, 2021 2 commits
  12. 24 May, 2021 2 commits
    • David Fifield's avatar
      Release resources in client Transport.Dial on error. · ae7cc478
      David Fifield authored
      Make a stack of cleanup functions to run (as with defer), but clear the
      stack before returning if no error occurs.
      
      Uselessly pushing the stream.Close() cleanup just before clearing the
      stack is an intentional safeguard, for in case additional operations are
      added before the return in the future.
      
      Fixes #40042.
      ae7cc478
    • David Fifield's avatar
      Fix error handling around transport.Dial. · 01a96c7d
      David Fifield authored
      The code checked for and displayed an error, but would then go on to
      call copyLoop on the nil Conn returned from transport.Dial. Add a return
      in that case, and put the cleanup operations in defer. Also remove an
      obsolete comment about an empty address. Obsolete because:
      !31 (comment 2733279)
      01a96c7d
  13. 21 May, 2021 1 commit
  14. 20 May, 2021 1 commit
    • Arlo Breault's avatar
      Remove sync.Once from around logMetrics · 7ef49272
      Arlo Breault authored
      Follow up to 160ae2dd
      
      Analysis by @dcf,
      
      > I don't think the sync.Once around logMetrics is necessary anymore.
      Its original purpose was to inhibit logging on later file handles of
      metrics.log, if there were more than one opened. See 171c55a9 and #29734
      (comment 2593039) "Making a singleton *Metrics variable causes problems
      with how Convey does tests. It shouldn't be called more than once, but
      for now I'm using sync.Once on the logging at least so it's explicit."
      Commit ba4fe1a7 changed it so that metrics.log is opened in main, used
      to create a *log.Logger, and that same instance of *log.Logger is passed
      to both NewMetrics and NewBrokerContext. It's safe to share the same
      *log.Logger across multiple BrokerContext.
      7ef49272
  15. 19 May, 2021 1 commit
    • Arlo Breault's avatar
      Make promMetrics not a global · 160ae2dd
      Arlo Breault authored
      Doesn't seem like it needs to exist outside of the metrics struct.
      
      Also, the call to logMetrics is moved to the constructor.  A metrics
      instance is only created when a BrokerContext is created, which only
      happens at startup.  The sync of only doing that once is left for
      documentation purposes, since it doesn't hurt, but also seems redundant.
      160ae2dd