Skip to content
  • Nick Mathewson's avatar
    Hand-conversion and audit phase of memcmp transition · 59f9097d
    Nick Mathewson authored
    Here I looked at the results of the automated conversion and cleaned
    them up as follows:
    
       If there was a tor_memcmp or tor_memeq that was in fact "safe"[*] I
       changed it to a fast_memcmp or fast_memeq.
    
       Otherwise if there was a tor_memcmp that could turn into a
       tor_memneq or tor_memeq, I converted it.
    
    This wants close attention.
    
    [*] I'm erring on the side of caution here, and leaving some things
    as tor_memcmp that could in my opinion use the data-dependent
    fast_memcmp variant.
    59f9097d