• Nick Mathewson's avatar
    Don't pass a NULL into a %s when logging client auth file load failure · ff558403
    Nick Mathewson authored
    Fortunately, in we improved logging for various
    failure cases involved with onion service client auth.
    Unfortunately, for this one, we freed the file right before logging
    its name.
    Fortunately, tor_free() sets its pointer to NULL, so we didn't have
    a use-after-free bug.
    Unfortunately, passing NULL to %s is not defined.
    Fortunately, GCC 9.1.1 caught the issue!
    Unfortunately, nobody has actually tried building Tor with GCC 9.1.1
    before. Or if they had, they didn't report the warning.
    Fixes bug 30475; bugfix on