Commit 4533a46e authored by Roger Dingledine's avatar Roger Dingledine
Browse files

move the assert higher up so the error message makes more sense 

next time.


svn:r3887
parent fcfe6d2e

src/or/connection_edge.c

+1 −1
Original line number Diff line number Diff line
@@ -1218,11 +1218,11 @@ void connection_ap_handshake_socks_reply(connection_t *conn, char *reply, 
                                         size_t replylen,

                                         socks5_reply_status_t status) {

  char buf[256];

  tor_assert(conn->socks_request); /* make sure it's an AP stream */



  control_event_stream_status(conn,

     status==SOCKS5_SUCCEEDED ? STREAM_EVENT_SUCCEEDED : STREAM_EVENT_FAILED);



  tor_assert(conn->socks_request);

  if (conn->socks_request->has_finished) {

    log_fn(LOG_WARN, "Harmless bug: duplicate calls to connection_ap_handshake_socks_reply.");

    return;