Commit 680646e0 authored by Sebastian Hahn's avatar Sebastian Hahn
Browse files

Don't use signed 1-bit bitfields

This was harmless, we never compared it to anything but itself or 0.
But Coverity complained, and it had a point.
parent 9e56ac27
...@@ -4,4 +4,5 @@ ...@@ -4,4 +4,5 @@
o Minor bugfixes: o Minor bugfixes:
- Add some forgotten return value checks during unit tests. Found - Add some forgotten return value checks during unit tests. Found
by coverity. by coverity.
- Don't use 1-bit wide signed bit fields. Found by coverity.
...@@ -45,7 +45,7 @@ typedef struct policy_summary_item_t { ...@@ -45,7 +45,7 @@ typedef struct policy_summary_item_t {
uint16_t prt_max; /**< Highest port number to accept/reject. */ uint16_t prt_max; /**< Highest port number to accept/reject. */
uint64_t reject_count; /**< Number of IP-Addresses that are rejected to uint64_t reject_count; /**< Number of IP-Addresses that are rejected to
this port range. */ this port range. */
int accepted:1; /** Has this port already been accepted */ unsigned int accepted:1; /** Has this port already been accepted */
} policy_summary_item_t; } policy_summary_item_t;
/** Private networks. This list is used in two places, once to expand the /** Private networks. This list is used in two places, once to expand the
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment