Commit 70c43e15 authored by Roger Dingledine's avatar Roger Dingledine
Browse files

note bug in assert_connection_ok 


svn:r1159
parent dd632e69

src/or/connection.c

+6 −2
Original line number Diff line number Diff line
@@ -840,9 +840,13 @@ void assert_connection_ok(connection_t *conn, time_t now) 
    assert(!conn->tls);

  } else {

    if(conn->state == OR_CONN_STATE_OPEN) {

      assert(conn->bandwidth > 0);

      /* assert(conn->bandwidth > 0); */

      /* the above isn't necessarily true: if we just did a TLS

       * handshake but we didn't recognize the other peer, or it

       * gave a bad cert/etc, then we won't have assigned bandwidth,

       * yet it will be open. -RD

       */

      assert(conn->receiver_bucket >= 0);

//      assert(conn->receiver_bucket <= 10*conn->bandwidth);

    }

    assert(conn->addr && conn->port);

    assert(conn->address);

src/or/onion.c

+1 −1
Original line number Diff line number Diff line
@@ -334,7 +334,7 @@ static routerinfo_t *choose_good_exit_server(routerlist_t *dir) 
  smartlist_free(sl);

  tor_free(n_supported);

  if(router) {

    log_fn(LOG_WARN, "Chose exit server '%s'", router->nickname);

    log_fn(LOG_INFO, "Chose exit server '%s'", router->nickname);

    return router;

  }

  log_fn(LOG_WARN, "No exit routers seem to be running; can't choose an exit.");