Commit 7dbf2511 authored by Roger Dingledine's avatar Roger Dingledine
Browse files

when you type 'getinfo' with no arguments, it doesn't give you 

any answer at all. this is clearly a bug.

the more interesting bug is whether things like setconf, getconf,
and so on should return 250 OK if you give them no arguments. should
we have a new "you didn't ask me anything" response code, or just
leave it as is?


svn:r5412
parent 24ea1b36

src/or/control.c

+1 −1
Original line number Diff line number Diff line
@@ -1452,7 +1452,7 @@ handle_control_getinfo(connection_t *conn, uint32_t len, const char *body) 
    tor_assert(msg_len > 0); /* it will at least be terminated */

    send_control0_message(conn, CONTROL0_CMD_INFOVALUE,

                          msg_len, msg);

  } else if (smartlist_len(answers)) {

  } else {

    int i;

    for (i = 0; i < smartlist_len(answers); i += 2) {

      char *k = smartlist_get(answers, i);