Commit 85076992 authored by Nick Mathewson's avatar Nick Mathewson 🐻
Browse files

r11624@catbus: nickm | 2007-02-01 13:17:35 -0500

 Note a few questionable bits pointed out by RATS.  (And no, RATS, I'm not about to stop having fixed-sized local buffers for you.  I know how to use them, thankyouverymuch.)


svn:r9474
parent 6f2a92c5
......@@ -231,6 +231,8 @@ logv(int severity, uint32_t domain, const char *funcname, const char *format,
}
if (lf->is_syslog) {
#ifdef HAVE_SYSLOG_H
/* XXXX Some syslog implementations have scary limits on the length of
* what you can pass them. Can/should we detect this? */
syslog(severity, "%s", end_of_prefix);
#endif
lf = lf->next;
......
......@@ -2768,6 +2768,7 @@ load_nameservers_with_getnetworkparams(void)
IP_ADDR_STRING *ns;
GetNetworkParams_fn_t fn;
/* XXXX Possibly, we should hardcode the location of this DLL. */
if (!(handle = LoadLibrary("iphlpapi.dll"))) {
log(EVDNS_LOG_WARN, "Could not open iphlpapi.dll");
//right now status = 0, doesn't that mean "good" - mikec
......
......@@ -1775,6 +1775,7 @@ nt_service_loadlibrary(void)
if (service_fns.loaded)
return 0;
/* XXXX Possibly, we should hardcode the location of this DLL. */
if (!(library = LoadLibrary("advapi32.dll"))) {
log_err(LD_GENERAL, "Couldn't open advapi32.dll. Are you trying to use "
"NT services on Windows 98? That doesn't work.");
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment