Unverified Commit 9fa38bd9 authored by Alexander Hansen Færøy's avatar Alexander Hansen Færøy 💬
Browse files

Check the return value of hs_parse_address(). 

This patch adds a check for the return value of `hs_parse_address()` in
`hs_control_hspost_command()`. Since it should not be possible for
`hs_parse_address()` to fail in this context we wrap the error check
with the `BUG()` macro.

See: https://bugs.torproject.org/24543
parent 01700d77

src/or/hs_control.c

+3 −1
Original line number Diff line number Diff line
@@ -222,7 +222,9 @@ hs_control_hspost_command(const char *body, const char *onion_address, 


  /* This can't fail because we require the caller to pass us a valid onion

   * address that has passed hs_address_is_valid(). */

  hs_parse_address(onion_address, &identity_pk, NULL, NULL);

  if (BUG(hs_parse_address(onion_address, &identity_pk, NULL, NULL) < 0)) {

    goto done; // LCOV_EXCL_LINE

  }



  /* Only decode the plaintext part which is what the directory will do to

   * validate before caching. */