Commit a49f506e authored by Nick Mathewson's avatar Nick Mathewson 🦀
Browse files

Split all controller events code into a new control_events.c 

Also, split the formatting code shared by control.c and
control_events.c into controller_fmt.c.
parent d4d541c5

scripts/maint/practracker/exceptions.txt

+9 −9
Original line number Diff line number Diff line
@@ -59,13 +59,13 @@ problem function-size /src/core/or/relay.c:connection_edge_process_relay_cell_no 
problem function-size /src/core/or/relay.c:connection_edge_process_relay_cell() 520

problem function-size /src/core/or/relay.c:connection_edge_package_raw_inbuf() 130

problem function-size /src/core/or/relay.c:circuit_resume_edge_reading_helper() 148

problem file-size /src/core/mainloop/mainloop.c 3050

problem include-count /src/core/mainloop/mainloop.c 65

problem file-size /src/core/mainloop/mainloop.c 3051

problem include-count /src/core/mainloop/mainloop.c 66

problem function-size /src/core/mainloop/mainloop.c:conn_close_if_marked() 108

problem function-size /src/core/mainloop/mainloop.c:run_connection_housekeeping() 123

problem function-size /src/core/mainloop/mainloop.c:CALLBACK() 116

problem file-size /src/core/mainloop/connection.c 5547

problem include-count /src/core/mainloop/connection.c 60

problem file-size /src/core/mainloop/connection.c 5548

problem include-count /src/core/mainloop/connection.c 61

problem function-size /src/core/mainloop/connection.c:connection_free_minimal() 184

problem function-size /src/core/mainloop/connection.c:connection_listener_new() 328

problem function-size /src/core/mainloop/connection.c:connection_handle_listener_read() 161
@@ -79,8 +79,8 @@ problem function-size /src/core/mainloop/connection.c:connection_handle_write_im 
problem function-size /src/core/mainloop/connection.c:assert_connection_ok() 143

problem function-size /src/app/config/confparse.c:config_assign_value() 205

problem function-size /src/app/config/confparse.c:config_get_assigned_option() 129

problem file-size /src/app/config/config.c 8488

problem include-count /src/app/config/config.c 84

problem file-size /src/app/config/config.c 8489

problem include-count /src/app/config/config.c 85

problem function-size /src/app/config/config.c:options_act_reversible() 296

problem function-size /src/app/config/config.c:options_act() 588

problem function-size /src/app/config/config.c:resolve_my_address() 192
@@ -96,7 +96,7 @@ problem function-size /src/app/config/config.c:parse_port_config() 452 
problem function-size /src/app/config/config.c:parse_ports() 170

problem function-size /src/app/config/config.c:getinfo_helper_config() 116

problem function-size /src/app/main/ntmain.c:nt_service_install() 125

problem include-count /src/app/main/main.c 83

problem include-count /src/app/main/main.c 84

problem function-size /src/app/main/main.c:dumpstats() 102

problem function-size /src/app/main/main.c:tor_init() 136

problem function-size /src/app/main/main.c:sandbox_init_filter() 291
@@ -110,7 +110,7 @@ problem function-size /src/feature/keymgt/loadkey.c:ed_key_init_from_file() 333 
problem function-size /src/feature/dircommon/consdiff.c:gen_ed_diff() 204

problem function-size /src/feature/dircommon/consdiff.c:apply_ed_diff() 159

problem file-size /src/feature/control/control.c 7592

problem include-count /src/feature/control/control.c 83

problem include-count /src/feature/control/control.c 90

problem function-size /src/feature/control/control.c:handle_control_authenticate() 188

problem function-size /src/feature/control/control.c:getinfo_helper_misc() 109

problem function-size /src/feature/control/control.c:getinfo_helper_dir() 304
@@ -122,7 +122,7 @@ problem function-size /src/feature/control/control.c:handle_control_hspost() 117 
problem function-size /src/feature/control/control.c:handle_control_add_onion() 293

problem function-size /src/feature/control/control.c:add_onion_helper_keyarg() 125

problem function-size /src/feature/control/control.c:connection_control_process_inbuf() 239

problem function-size /src/feature/control/control.c:control_event_stream_status() 119

problem function-size /src/feature/control/control_events.c:control_event_stream_status() 119

problem function-size /src/feature/stats/rephist.c:rep_hist_load_mtbf_data() 185

problem function-size /src/feature/stats/rephist.c:rep_hist_format_exit_stats() 148

problem function-size /src/feature/dircache/consdiffmgr.c:consdiffmgr_cleanup() 115

src/app/config/config.c

+1 −0
Original line number Diff line number Diff line
@@ -86,6 +86,7 @@ 
#include "feature/client/entrynodes.h"

#include "feature/client/transports.h"

#include "feature/control/control.h"

#include "feature/control/control_events.h"

#include "feature/dirauth/bwauth.h"

#include "feature/dirauth/guardfraction.h"

#include "feature/dircache/consdiffmgr.h"

src/app/config/statefile.c

+1 −1
Original line number Diff line number Diff line
@@ -36,7 +36,7 @@ 
#include "core/mainloop/mainloop.h"

#include "core/mainloop/netstatus.h"

#include "core/mainloop/connection.h"

#include "feature/control/control.h"

#include "feature/control/control_events.h"

#include "feature/client/entrynodes.h"

#include "feature/hibernate/hibernate.h"

#include "feature/stats/rephist.h"

src/app/main/main.c

+1 −0
Original line number Diff line number Diff line
@@ -43,6 +43,7 @@ 
#include "feature/client/entrynodes.h"

#include "feature/client/transports.h"

#include "feature/control/control.h"

#include "feature/control/control_events.h"

#include "feature/dirauth/bwauth.h"

#include "feature/dirauth/keypin.h"

#include "feature/dirauth/process_descs.h"

src/core/include.am

+4 −0
Original line number Diff line number Diff line
@@ -71,6 +71,8 @@ LIBTOR_APP_A_SOURCES = \ 
	src/feature/control/btrack_orconn_maps.c	\

	src/feature/control/control.c		\

	src/feature/control/control_bootstrap.c	\

	src/feature/control/control_events.c	\

	src/feature/control/control_fmt.c	\

	src/feature/control/fmt_serverstatus.c  \

	src/feature/control/getinfo_geoip.c	\

	src/feature/dirauth/keypin.c		\
@@ -288,6 +290,8 @@ noinst_HEADERS += \ 
	src/feature/control/btrack_sys.h		\

	src/feature/control/control.h			\

	src/feature/control/control_connection_st.h	\

	src/feature/control/control_events.h	        \

	src/feature/control/control_fmt.h                \

	src/feature/control/fmt_serverstatus.h		\

	src/feature/control/getinfo_geoip.h		\

	src/feature/dirauth/authmode.h			\