Commit b28a342e authored by Roger Dingledine's avatar Roger Dingledine
Browse files

resolve one more, and leave two for nick.


svn:r13644
parent 1812a22a
...@@ -285,7 +285,8 @@ tor_tls_get_error(tor_tls_t *tls, int r, int extra, ...@@ -285,7 +285,8 @@ tor_tls_get_error(tor_tls_t *tls, int r, int extra,
log(severity, LD_NET, "TLS error: Zero return"); log(severity, LD_NET, "TLS error: Zero return");
tls_log_errors(tls, severity, doing); tls_log_errors(tls, severity, doing);
/* XXXX020rc Actually, a 'zero return' error has a pretty specific /* XXXX020rc Actually, a 'zero return' error has a pretty specific
* meaning: the connection has been closed cleanly. */ * meaning: the connection has been closed cleanly. -NM
* Great. Do something smart here then. :) -RD */
return TOR_TLS_ERROR_MISC; return TOR_TLS_ERROR_MISC;
default: default:
tls_log_errors(tls, severity, doing); tls_log_errors(tls, severity, doing);
......
...@@ -1861,7 +1861,8 @@ loop_again: ...@@ -1861,7 +1861,8 @@ loop_again:
* we need to invoke the appropriate callbacks ourself. */ * we need to invoke the appropriate callbacks ourself. */
connection_t *linked = conn->linked_conn; connection_t *linked = conn->linked_conn;
/* XXXX020rc Do we need to ensure that this stuff is called even if /* XXXX020rc Do we need to ensure that this stuff is called even if
* conn dies in a way that causes us to return -1 earlier? */ * conn dies in a way that causes us to return -1 earlier? -NM
* No idea. -RD */
if (n_read) { if (n_read) {
/* Probably a no-op, but hey. */ /* Probably a no-op, but hey. */
......
...@@ -592,6 +592,8 @@ dns_resolve(edge_connection_t *exitconn) ...@@ -592,6 +592,8 @@ dns_resolve(edge_connection_t *exitconn)
// main.c. -NM // main.c. -NM
// "<armadev> If that's true, there are other bugs around, where we // "<armadev> If that's true, there are other bugs around, where we
// don't check if it's marked, and will end up double-freeing." // don't check if it's marked, and will end up double-freeing."
// On the other hand, I don't know of any actual bugs here, so this
// shouldn't be holding up the rc. -RD
} }
break; break;
default: default:
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment