Commit c90d6c7e authored by Nick Mathewson's avatar Nick Mathewson 🏃
Browse files

Make arguments to circuit_set_circid_orconn match the connection that is...

Make arguments to circuit_set_circid_orconn match the connection that is closing in circuit_about_to_close_connection. This accounts for our mysterious "arbitrary ram gets decremented!" bug.


svn:r5465
parent 7de0c338
......@@ -516,10 +516,10 @@ circuit_about_to_close_connection(connection_t *conn)
SMARTLIST_FOREACH(circs, circuit_t *, circ, {
if (circ->n_conn == conn)
/* it's closing in front of us */
circuit_set_circid_orconn(circ, 0, NULL, P_CONN_CHANGED);
circuit_set_circid_orconn(circ, 0, NULL, N_CONN_CHANGED);
if (circ->p_conn == conn)
/* it's closing behind us */
circuit_set_circid_orconn(circ, 0, NULL, N_CONN_CHANGED);
circuit_set_circid_orconn(circ, 0, NULL, P_CONN_CHANGED);
circuit_mark_for_close(circ);
});
smartlist_free(circs);
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment