r18228@catbus: nickm | 2008-02-19 18:05:53 -0500

 Chris Palmer notes that almost nobody is using smartlist_set_capacity().  Chris Palmer is right.  Remove this basically pointless function.


svn:r13596

src/common/container.c

@@ -55,25 +55,6 @@ smartlist_free(smartlist_t *sl)
   tor_free(sl);
 }
 
-/** Change the capacity of the smartlist to <b>n</b>, so that we can grow
- * the list up to <b>n</b> elements with no further reallocation or wasted
- * space.  If <b>n</b> is less than or equal to the number of elements
- * currently in the list, reduce the list's capacity as much as
- * possible without losing elements.
- */
-void
-smartlist_set_capacity(smartlist_t *sl, int n)
-{
-  if (n < sl->num_used)
-    n = sl->num_used;
-  if (n < 1)
-    n = 1;
-  if (sl->capacity != n) {
-    sl->capacity = n;
-    sl->list = tor_realloc(sl->list, sizeof(void*)*sl->capacity);
-  }
-}
-
 /** Remove all elements from the list.
  */
 void

src/common/container.h

@@ -29,7 +29,6 @@ typedef struct smartlist_t {
 
 smartlist_t *smartlist_create(void);
 void smartlist_free(smartlist_t *sl);
-void smartlist_set_capacity(smartlist_t *sl, int n);
 void smartlist_clear(smartlist_t *sl);
 void smartlist_add(smartlist_t *sl, void *element);
 void smartlist_add_all(smartlist_t *sl, const smartlist_t *s2);

src/or/rendservice.c

@@ -158,7 +158,6 @@ rend_add_service(rend_service_t *service)
     log_warn(LD_CONFIG, "Hidden service with no ports configured; ignoring.");
     rend_service_free(service);
   } else {
-    smartlist_set_capacity(service->ports, -1);
     smartlist_add(rend_service_list, service);
     log_debug(LD_REND,"Configuring service with directory \"%s\"",
               service->directory);