1. 02 Sep, 2014 2 commits
    • Nick Mathewson's avatar
      Another clang analyzer complaint wrt HT_GENERATE · 00ffccd9
      Nick Mathewson authored
      We're calling mallocfn() and reallocfn() in the HT_GENERATE macro
      with the result of a product.  But that makes any sane analyzer
      worry about overflow.
      
      This patch keeps HT_GENERATE having its old semantics, since we
      aren't the only project using ht.h.  Instead, define a HT_GENERATE2
      that takes a reallocarrayfn.
      00ffccd9
    • Nick Mathewson's avatar
      Fix a number of clang analyzer false-positives · efcab439
      Nick Mathewson authored
      Most of these are in somewhat non-obvious code where it is probably
      a good idea to initialize variables and add extra assertions anyway.
      
      Closes 13036.  Patches from "teor".
      efcab439
  2. 01 Sep, 2014 2 commits
  3. 29 Aug, 2014 3 commits
  4. 28 Aug, 2014 1 commit
    • Roger Dingledine's avatar
      Resume expanding abbreviations for command-line options · 37a76d75
      Roger Dingledine authored and Nick Mathewson's avatar Nick Mathewson committed
      The fix for bug 4647 accidentally removed our hack from bug 586 that
      rewrote HashedControlPassword to __HashedControlSessionPassword when
      it appears on the commandline (which allowed the user to set her own
      HashedControlPassword in the torrc file while the controller generates
      a fresh session password for each run).
      
      Fixes bug 12948; bugfix on 0.2.5.1-alpha.
      37a76d75
  5. 25 Aug, 2014 1 commit
  6. 24 Aug, 2014 5 commits
  7. 22 Aug, 2014 1 commit
    • Nick Mathewson's avatar
      Tidy status handling in rendservice.c · d31bcc4b
      Nick Mathewson authored
      We had some code to fix up the 'status' return value to -1 on error
      if it wasn't set, but it was unreachable because our code was
      correct.  Tweak this by initializing status to -1, and then only
      setting it to 0 on success.  Also add a goto which was missing: its
      absence was harmless.
      
      [CID 718614, 718616]
      d31bcc4b
  8. 21 Aug, 2014 6 commits
  9. 20 Aug, 2014 6 commits
  10. 18 Aug, 2014 3 commits
  11. 15 Aug, 2014 9 commits
  12. 13 Aug, 2014 1 commit