1. 08 Dec, 2017 1 commit
  2. 16 Nov, 2017 1 commit
    • Nick Mathewson's avatar
      Downgrade evdns warnings about weird replies. · 2a98fcb8
      Nick Mathewson authored
      evdns is allowed to give us unrecognized object types; it is allowed
      to give us non-IPv4 answer types, and it is (even) allowed to give
      us empty answers without an error.
      
      Closes ticket 24097.
      2a98fcb8
  3. 09 Nov, 2017 1 commit
    • Nick Mathewson's avatar
      Audit all of the "is the network turned off" checks. · 0c6eabf0
      Nick Mathewson authored
      DisableNetwork is a subset of net_is_disabled(), which is (now) a
      subset of should_delay_dir_fetches().
      
      Some of these changes are redundant with others higher or lower in
      the call stack.  The ones that I think are behavior-relevant are
      listed in the changes file.  I've also added comments in a few
      places where the behavior is subtle.
      
      Fixes bug 12062; bugfix on various versions.
      0c6eabf0
  4. 05 Nov, 2017 1 commit
  5. 15 Sep, 2017 1 commit
  6. 11 Sep, 2017 1 commit
  7. 03 Aug, 2017 1 commit
  8. 01 Jul, 2017 1 commit
  9. 23 Jun, 2017 1 commit
  10. 30 May, 2017 1 commit
  11. 26 May, 2017 1 commit
  12. 15 May, 2017 1 commit
  13. 15 Mar, 2017 1 commit
  14. 18 Jan, 2017 2 commits
  15. 27 Oct, 2016 1 commit
    • overcaffeinated's avatar
      Automated change to use smartlist_add_strdup · 265d5446
      overcaffeinated authored
      Use the following coccinelle script to change uses of
      smartlist_add(sl, tor_strdup(str)) to
      smartlist_add_strdup(sl, string) (coccinelle script from nickm
      via bug 20048):
      
      @@
      expression a;
      expression b;
      @@
      - smartlist_add
      + smartlist_add_strdup
         (a,
      - tor_strdup(
         b
      - )
        )
      265d5446
  16. 17 Oct, 2016 1 commit
    • Nick Mathewson's avatar
      Write a bunch of module documentation. · aae034d1
      Nick Mathewson authored
      This commit adds or improves the module-level documenation for:
      
        buffers.c circuitstats.c command.c connection_edge.c control.c
        cpuworker.c crypto_curve25519.c crypto_curve25519.h
        crypto_ed25519.c crypto_format.c dircollate.c dirserv.c dns.c
        dns_structs.h fp_pair.c geoip.c hibernate.c keypin.c ntmain.c
        onion.c onion_fast.c onion_ntor.c onion_tap.c periodic.c
        protover.c protover.h reasons.c rephist.c replaycache.c
        routerlist.c routerparse.c routerset.c statefile.c status.c
        tor_main.c workqueue.c
      
      In particular, I've tried to explain (for each documented module)
      what each module does, what's in it, what the big idea is, why it
      belongs in Tor, and who calls it.  In a few cases, I've added TODO
      notes about refactoring opportunities.
      
      I've also renamed an argument, and fixed a few DOCDOC comments.
      aae034d1
  17. 04 Jul, 2016 1 commit
  18. 27 Feb, 2016 1 commit
  19. 15 Dec, 2015 1 commit
  20. 24 Oct, 2015 3 commits
  21. 23 Aug, 2015 1 commit
  22. 14 Mar, 2015 1 commit
  23. 08 Jan, 2015 1 commit
  24. 02 Jan, 2015 1 commit
  25. 28 Oct, 2014 1 commit
  26. 02 Sep, 2014 1 commit
    • Nick Mathewson's avatar
      Another clang analyzer complaint wrt HT_GENERATE · 00ffccd9
      Nick Mathewson authored
      We're calling mallocfn() and reallocfn() in the HT_GENERATE macro
      with the result of a product.  But that makes any sane analyzer
      worry about overflow.
      
      This patch keeps HT_GENERATE having its old semantics, since we
      aren't the only project using ht.h.  Instead, define a HT_GENERATE2
      that takes a reallocarrayfn.
      00ffccd9
  27. 06 May, 2014 1 commit
  28. 17 Apr, 2014 1 commit
  29. 08 Apr, 2014 1 commit
  30. 12 Feb, 2014 1 commit
    • Nick Mathewson's avatar
      Siphash-2-4 is now our hash in nearly all cases. · 0e97c8e2
      Nick Mathewson authored
      I've made an exception for cases where I'm sure that users can't
      influence the inputs.  This is likely to cause a slowdown somewhere,
      but it's safer to siphash everything and *then* look for cases to
      optimize.
      
      This patch doesn't actually get us any _benefit_ from siphash yet,
      since we don't really randomize the key at any point.
      0e97c8e2
  31. 20 Sep, 2013 1 commit
  32. 19 Aug, 2013 1 commit
  33. 12 Aug, 2013 1 commit
  34. 26 Jul, 2013 1 commit
  35. 01 Feb, 2013 1 commit
    • Nick Mathewson's avatar
      Rename log() to tor_log() for logging · a141430e
      Nick Mathewson authored
      This is meant to avoid conflict with the built-in log() function in
      math.h.  It resolves ticket 7599.  First reported by dhill.
      
      This was generated with the following perl script:
      
       #!/usr/bin/perl -w -i -p
      
       s/\blog\(LOG_(ERR|WARN|NOTICE|INFO|DEBUG)\s*,\s*/log_\L$1\(/g;
      
       s/\blog\(/tor_log\(/g;
      a141430e
  36. 16 Jan, 2013 2 commits
    • Nick Mathewson's avatar
      Aftermath of isin->contains renaming · ca18768f
      Nick Mathewson authored
      Fix wide lines and comments, and add a changes file
      ca18768f
    • Nick Mathewson's avatar
      Rename *_isin to *_contains · 49e619c1
      Nick Mathewson authored
      This is an automatically generated commit, from the following perl script,
      run with the options "-w -i -p".
      
        s/smartlist_string_num_isin/smartlist_contains_int_as_string/g;
        s/smartlist_string_isin((?:_case)?)/smartlist_contains_string$1/g;
        s/smartlist_digest_isin/smartlist_contains_digest/g;
        s/smartlist_isin/smartlist_contains/g;
        s/digestset_isin/digestset_contains/g;
      49e619c1