A couple of last minor TODO cleanup items


svn:r8462

on the list.


svn:r8461

svn:r8458

svn:r8457

 Revise patch for libevent 1.1b to handle the "wait, I *do* have a gettimeofday()" case.


svn:r8456

svn:r8455

 I tracked a bug in server-side reverse DNS to something concerning the caching code. Ive disabled server-side cacheing for reverse DNS answers for now, and I am noting the bug in the TODO.


svn:r8454

svn:r8453

 Debug client-side reverse dns code.


svn:r8452

 Specify and implement SOCKS5 interface for reverse hostname lookup.


svn:r8451

svn:r8450

svn:r8449

svn:r8448

svn:r8447

 Allow resolve requests to non-exits when they are specifically requested (via resolve foo.bar.exit).


svn:r8446

 Trivial patch to appease warn-happy gcc: mark unused parameter


svn:r8445

 Oops from earlier patch; add "opt eventdns" to unittests, fix bug in routerdesc generation.


svn:r8444

 Trivial whitespace cleanups.


svn:r8443

 Consider non-exit servers unsuitable for RESOLVE commands.


svn:r8442

 Trivial cleanup: !!x is a weird way to spell x != NULL.


svn:r8441

 Resolve bug 330: detect ISPs that want to hijack failing DNS requests and basically domain-squat the entire internet.


svn:r8440

 Rename and document SearchDomains and ResolvConf options; warn if ServerDNSResolvConfFile is given but eventdns isnt enabled.


svn:r8439

 Fix a bug: Remember, each call to escaped() replaces the value returned from the last call to escaped().


svn:r8438

 Implement server-side reverse DNS using eventdns.  Add an option to routerdescs so we can tell which servers have eventdns enabled.


svn:r8437

svn:r8434

NEEDS REVIEW. Act on previous comment, and handle named servers differently: now, we allow multiple servers with the same name in the routerlist even if that name is reserved, but we check whether names are reserved when we try to look up routers by nickname. This is a minor security fix.  This makes router_add_to_routerlist O(1). This is a backport candidate.

svn:r8433

Stop searching routerlist for routers with the same identity as other routers (on router insert): we already have a map for that.  (We need to add an index field to routerinfo_t so we can figure out which point in the routerlist to replace.)  Also, add a comment to routerlist.c; arma, please advise?

svn:r8432

Malloc and friends are critical-path: Thus, add an it-wont-happen branch prediction for NULL returns, and skip the malloc(0) check on platforms where malloc(0) returns a pointer.

svn:r8431

Switch routerlist.c to using memcmp on digests rather than crypto_pk_cmp_keys(); speed up find_whitespace a lot (8x for me) by using a switch statement.  This should speed parsing a lot of routers at once by a lot.

svn:r8430

svn:r8429

svn:r8428

svn:r8427

svn:r8416

minutes, trying to establish reachability of my unreachable server.


svn:r8415

Second, if you give an unknown purpose, it would say:
552 Unknown purpose "purpose=foo"
Now it just says
552 Unknown purpose "foo"


svn:r8412

 Move more todo items around


svn:r8411

 Add some client performance XXXXs; try to move some common case tests higher on their decision trees.


svn:r8410

 More TODO work; tenatively mark assignments.


svn:r8409

svn:r8408

where if circuits fail quickly, we'll fail a lot of them very
quickly and not retry for a while. so be it.


svn:r8407