Some *_free functions threw asserts when passed NULL. Now all of them
accept NULL as input and perform no action when called that way.

This gains us consistence for our free functions, and allows some
code simplifications where an explicit null check is no longer necessary.

New config option "CircuitStreamTimeout" to override our internal
timeout schedule for how many seconds until we detach a stream from
a circuit and try a new circuit. If your network is particularly
slow, you might want to set this to a number like 60.

Sebastian Hahn authored Sep 26, 2009 and Nick Mathewson committed Sep 27, 2009

Found by Coverity

This reverts commit dc322931.

We're going to do this more thoroughly in 0.2.2.x, and not in
maint-0.2.1.

To further attempt to fix bug 1090, make sure connection_ap_can_use_exit
always returns 0 when the chosen exit router is excluded. This should fix
bug1090.

This is a patch to remove support for .noconnect.
We are removing .noconnect because of a talk at Defcon 17 by Gregory Fleischer.

Changes to directory request statistics:

- Rename GEOIP statistics to DIRREQ statistics, because they now include
  more than only GeoIP-based statistics, whereas other statistics are
  GeoIP-dependent, too.
- Rename output file from geoip-stats to dirreq-stats.
- Add new config option DirReqStatistics that is required to measure
  directory request statistics.
- Clean up ChangeLog.

Also ensure that entry guards statistics have access to a local GeoIP
database.

- Use common prefixes DIRREQ_* and dirreq_*.
- Replace enums in structs with bitfields.

Patch by Roger; fixes bug 1027.

Karsten Loesing authored Jun 24, 2009 and Nick Mathewson committed Jul 02, 2009

[Original patch series from Karsten, revised and squashed by Nick]

This reverts commit 3847f549.

Karsten Loesing authored Jun 16, 2009 and Nick Mathewson committed Jun 16, 2009

Backporting 6a32beb8 and ca8708a9.

The rest of the code was only including event.h so that it could see
EV_READ and EV_WRITE, which we were using as part of the
connection_watch_events interface for no very good reason.

Hidden service clients didn't use a cached service descriptor that
was older than 15 minutes, but wouldn't fetch a new one either. Now,
use a cached descriptor no matter how old it is and only fetch a new
one when all introduction points fail. Fix for bug 997. Patch from
Marcus Griep.

svn:r19295

svn:r19293

me further)


svn:r19292

IP address changes: directory mirrors were mistakenly telling them
their old address if they asked via begin_dir, so they never got
an accurate answer about their new address, so they just vanished
after a day. Should fix bugs 827, 883, and 900 -- but alas, only
after every directory mirror has upgraded.


svn:r19291

stream never finished making its connection, it would live
forever in circuit_wait state. Now we close it after SocksTimeout
seconds. Bugfix on 0.1.2.7-alpha; reported by Mike Perry.


svn:r18516

svn:r18477

(but not in 0.2.1.12-alpha, sorry)


svn:r18417

redundant, and is definitely confusing. we should take it out
in 0.2.2.x and see who squeaks.


svn:r18383

svn:r18299

svn:r18102

Preserve reporting of stream end reasons to the local control
port.  They were lost in the changes for Proposal 148.



svn:r17911

svn:r17888