In C, the code "char x[10]; if (x) {...}" always takes the true branch of
the if statement.  Coverity notices this now.

In some cases, we were testing arrays to make sure that an operation
we wanted to do would suceed.  Those cases are now always-true.

In some cases, we were testing arrays to see if something was _set_.
Those caes are now tests for strlen(s), or tests for
!tor_mem_is_zero(d,len).

The first happens on an error case when a controller wants an
impossible directory object.  The second happens when we can't write
our fingerprint file.

Big thanks to nickm and arma for helping me with this!

Add a "getinfo status/accepted-server-descriptor" controller
command, which is the recommended way for controllers to learn
whether our server descriptor has been successfully received by at
least on directory authority. Un-recommend good-server-descriptor
getinfo and status events until we have a better design for them.

it never really worked, and hasn't been used for years.

When a QUIT has been issued on a control port connection, then
ignore further commands on that port. This fixes bug 1016.

Marks the control port connection for flushing before closing when
the QUIT command is issued. This allows a QUIT to be issued during
a long reply over the control port, flushing the reply and then
closing the connection. Fixes bug 1015.

This patch adds a function to determine whether we're in the main
thread, and changes control_event_logmsg() to return immediately if
we're in a subthread.  This is necessary because otherwise we will
call connection_write_to_buf, which modifies non-locked data
structures.

Bugfix on 0.2.0.x; fix for at least one of the things currently
called "bug 977".

Supporting the old formats made our code complex; running without them
has been discouraged since 0.2.1.x.

svn:r19079

events, not if he's asked for ns events


svn:r18656

svn:r18566

svn:r18557

lines for every recommended relay.

still needs docdoc and changelog entry.


svn:r18556

svn:r18288

svn:r18287

a new event. what a mess.


svn:r18277

on 0.2.1.10-alpha; reported by Matt Edman.


svn:r18201

Fix up (I hope) most ot the things that coverity suddenly claimed were REVERSE_INULL.  This is what we get for bragging about being down to 0 issues.

svn:r18096

The subversion $Id$ fields made every commit force a rebuild of
whatever file got committed.  They were not actually useful for
telling the version of Tor files in the wild.

svn:r17867

svn:r17810

of which countries we've seen clients from recently. Now controllers
like Vidalia can show bridge operators that they're actually making
a difference.


svn:r17796

svn:r17793

svn:r17771

svn:r17754

svn:r17739

svn:r17735

svn:r17734

Add DOCDOC comments for all undocumented functions.  Add missing *s to other comments so that they will get recognized as doxygen.

svn:r17729

svn:r17727

svn:r17669