It's still not great, but should be less confusing what's wrong
here.

Closes ticket 1121.

in retrospect, we should have removed this with commit 1289474d
as part of #11742, which was the last caller of it.

No code changes needed: in the places where we actually check the
return value of these functions, we handle it correctly.

See: https://bugs.torproject.org/22305

See: https://bugs.torproject.org/22305

This patch lifts the return value, rv, variable to the beginning of the
function, adds a 'done' label for clean-up and function exit and makes
the rest of the function use the rv value + goto done; instead of
cleaning up in multiple places.

See: https://bugs.torproject.org/22305

This will help if we ever need to add more fields or change the
semantics of existing fields.

We used to not set the guard state in launch_direct_bridge_descriptor_fetch().
So when a bridge descriptor fetch failed, the guard subsystem would never
learn about the fail (and hence the guard's reachability state would not
be updated).

See: https://bugs.torproject.org/22305

Roger Dingledine authored May 21, 2017 and Nick Mathewson committed May 22, 2017

Directory authorities now reject relays running versions
0.2.9.1-alpha through 0.2.9.4-alpha, because those relays
suffer from bug 20499 and don't keep their consensus cache
up-to-date.

Resolves ticket 20509.

closes ticket 22322

This isn't elegant, but it seems to be the best way around all of
the issues involved in escaping and quoting that we've gotten into
over the years.

parse_config_line_from_str_verbose() already looks for strings
that are surrounded by quotes, and processes them with
unescape_string().  So things were getting decoded twice, which was
(in turn) playing havoc with backslashes on Windows.

It was trying to do %include "foo\", which won't work.  It has to be
%include "foo\\".